search

BHoM / SAP2000_Toolkit

GNU Lesser General Public License v3.0
9 stars 3 forks source link

SAP2000_Engine: JoinRigidLink() and SplitRigidLink() are not compliant for public methods #190

Closed JosefTaylor closed 8 months ago

JosefTaylor commented 3 years ago

Broken rules:

Join and Split rigid link methods are public, but lack descriptions. JoinRigidLink() also has an issue in Grasshopper where the component does not get list access, causing it to fail.

Suggestions to restore compliance:

Two options for fixing:

  1. Make them private - for the most part these are not needed in the public space, and if they are, they should be promoted to Structure_Engine.
  2. Give them descriptions and fix the grasshopper issues
FraserGreenroyd commented 3 years ago

@JosefTaylor is the Grasshopper issue related to https://github.com/BHoM/Grasshopper_Toolkit/issues/518 ? Not sure, just basing off the opening statement about list access.

JosefTaylor commented 3 years ago

@JosefTaylor is the Grasshopper issue related to BHoM/Grasshopper_Toolkit#518 ? Not sure, just basing off the opening statement about list access.

hmm, possible. I think this isn't an issue of versioning, but it ends up with the same problem, that the method takes a list, but GH doesn't give it a list.

FraserGreenroyd commented 8 months ago

It appears that over time this issue was resolved to give more information so I'm considering this complete for now 😄