BHoM / SAP2000_Toolkit

GNU Lesser General Public License v3.0
9 stars 3 forks source link

Correcting call to AdapterId #209

Closed IsakNaslundBh closed 3 years ago

IsakNaslundBh commented 3 years ago

NOTE: Depends on

Aligns with https://github.com/BHoM/BHoM_Adapter/pull/287 again after some more code has been added. THis is also compiling to master though, so not fully dependant.

Issues addressed by this PR

Closes #208

Could not use the same branch name as for the adapter as a PR had already been opened and merged fixing the issue before. Since then, new code has been added, where the issue has been re-introduced. This should compile to master though, hence this can be and needs to be merged before the Adapter PR.

Test files

I do not have SAP2000 on my machine, but code functionality change from this PR should be non

Changelog

Additional comments

IsakNaslundBh commented 3 years ago

@BHoMBot check all

bhombot-ci[bot] commented 3 years ago
@IsakNaslundBh sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to run? For a list of available instructions, please see [this wiki page](https://github.com/BHoM/documentation/wiki/Continuous-Integration).
IsakNaslundBh commented 3 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 3 years ago
@IsakNaslundBh to confirm, `check-code-compliance`, `check-documentation-compliance`, `check-project-compliance`, `check-branch-compliance`, `check-dataset-compliance`, and, if applicable, `check-copyright-compliance` tasks are now queued.
IsakNaslundBh commented 3 years ago

@BHoMBot check core

bhombot-ci[bot] commented 3 years ago
@IsakNaslundBh to confirm, `check-core` task is now queued.
IsakNaslundBh commented 3 years ago

@BHoMBot check installer

bhombot-ci[bot] commented 3 years ago
@IsakNaslundBh to confirm, `check-installer` task is now queued.
IsakNaslundBh commented 3 years ago

@BHoMBot check versioning

bhombot-ci[bot] commented 3 years ago
@IsakNaslundBh to confirm, `check-versioning` task is now queued.
IsakNaslundBh commented 3 years ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 3 years ago
@IsakNaslundBh to confirm, the task for checking if this Pull Request is ready to merge is now queued.