BHoM / SAP2000_Toolkit

GNU Lesser General Public License v3.0
9 stars 3 forks source link

SAP2000: Change IAverageThickness to ITotalThickness() #261

Closed JosefTaylor closed 2 years ago

JosefTaylor commented 2 years ago

Updated error message- area temperature gradients are now implemented in BHoM, raise issue in SAP to support.

NOTE: Depends on

https://github.com/BHoM/BHoM_Engine/pull/2819

Issues addressed by this PR

Average thickness is repurposed in the Structure_Engine. Instead relying on the ITotalThickness which is appropriate for a temperature gradient.

Test files

Changelog

Additional comments

JosefTaylor commented 2 years ago

@BHoMBot check compliance

bhombot-ci[bot] commented 2 years ago
@JosefTaylor to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `branch-compliance` - `dataset-compliance` - `copyright-compliance`
bhombot-ci[bot] commented 2 years ago
@JosefTaylor just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
JosefTaylor commented 2 years ago

@BHoMBot check required

bhombot-ci[bot] commented 2 years ago
@JosefTaylor to confirm, the following checks are now queued: - `code-compliance` - `documentation-compliance` - `project-compliance` - `core` - `null-handling` - `serialisation` - `versioning` - `installer` There are 31 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 years ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 years ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 2 years ago
@JosefTaylor just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@JosefTaylor just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine
bhombot-ci[bot] commented 2 years ago
@JosefTaylor just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine
IsakNaslundBh commented 2 years ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 2 years ago
@IsakNaslundBh to confirm, the following checks are now queued: - `ready-to-merge` There are 4 requests in the queue ahead of you.