6.1 Deployment

[bhombot-ci[bot]]

SAP2000_Toolkit

Feature

• Add panel fragments to read
• Added override to Delete method in toolkit.

  Compliance

• Update AssemblyFileVersion to 6.1
• Update Copyright Headers to 2023
• Update copyright headers to 2023 for new files

  Documentation

• Updating supported versions

[FraserGreenroyd]

@BHoMBot check beta-merge-status

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued: - check `beta-merge-status` There are 66 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot check beta-merge-status

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued: - check `beta-merge-status` There are 67 requests in the queue ahead of you.

[bhombot-ci[bot]]

MERGE REPORT - 2023-03-19 15:23. DETAILS: This pull request can be merged or not merged without impact on any of its upstream dependencies..

[IsakNaslundBh]

I followed the Structural Adapters Test Procedure document and used the corresponding test scripts. At the time that I'm submitting this review - I've only gone through about the first 5 sections, but wanted to post anyways since I know time has just about run out.

The first error I encountered was related to updating wall and floor elements which I modeled as panels:

"1. Failed to create the element of type Panel, with id: "

I was also unable to push loads of any kind (although the loadcase names were pushed):

1. This component failed to run properly.
- Error: Value cannot be null.
Parameter name: key
- Occured in  BH.Adapter.BHoMAdapter.CreateAndCache[T](IEnumerable`1 objects, ActionConfig actionConfig)
     called from BH.Adapter.BHoMAdapter.FullCRUD[T](IEnumerable`1 objectsToPush, PushType pushType, String tag, ActionConfig actionConfig)
- Are you sure you have the correct type of inputs? Check their description for more details."

For bar result outputs, BarDisplacements and BarForces were outputting the correct values, although I could not get the results to display in rhino with the test scripts (no errors were thrown though). I did get errors when trying to pull BarDeformations, BarStresses, and BarStrains, but these appear to just not be supported. (ex: "1. Result extraction of type BarStrain is not yet supported").

Thanks @LukeBastianBH

The problem with updating locations of Panels in SAP2000 is an API limitation, and something that has been there forever and I am not to worried about.

Messaging for sure could be made better potentially, but that is in my mind no reason to hold of merging this PR.

The load push completely failing on the other hand is.

I have raised a PR turning of the caching system for now, which I think should solve this issue. With that fixed I hope the load push should work fine.

For the Results, I think that sounds like things working as intended, maybe except for the display part, but that is unrelated to SAP, why again I do not think this should stop this PR.

All in all, the load push is critical, and hope the currently open PR will resolve the problem.

[FraserGreenroyd]

@BHoMBot check beta-merge-status

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued: - check `beta-merge-status`

[bhombot-ci[bot]]

MERGE REPORT - 2023-03-22 15:04. ERROR CODE(s): - DF001. DETAILS: - This pull request can NOT be merged without one or more of its upstream dependencies being merged. Merging this pull request without dependencies will cause compilation errors in this repository. See the check annotations for more information..

[FraserGreenroyd]

Owing to a lack of reviews signing off this repository for all of the changes proposed to this beta, I am unable to deploy this pull request to the 6.1 beta. Unfortunately it is also blocked by the inability to deploy one or more of the repositories higher up in this repositories dependency chain.

If there is sufficient demand, we may be able to look at doing a 6.1 beta patch and include it prior to the 6.2 beta.

I am closing this pull request to tidy up and complete the 6.1 deployment. The work will not be lost, and will be eligible for inclusion in the 6.2 beta if it is not deployed via a beta patch prior to the 6.2 beta.

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

[FraserGreenroyd]

@BHoMBot check compliance @BHoMBot check null-handling @BHoMBot check serialisation @BHoMBot check core

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `null-handling` - check `serialisation` - check `core` There are 79 requests in the queue ahead of you.

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-versioning` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit

[bhombot-ci[bot]]

@bhombot-ci[bot] just to let you know, I have provided a `check-installer` result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit

[FraserGreenroyd]

@BHoMBot check dataset-compliance

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued: - check `dataset-compliance` There are 6 requests in the queue ahead of you.

[bhombot-ci[bot]]

FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is beta-code-compliance. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `12306069199`

[bhombot-ci[bot]]

FAO: @FraserGreenroyd @FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is beta-documentation-compliance. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `12306079613`

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12306069199

[bhombot-ci[bot]]

@FraserGreenroyd I have now provided a passing check on reference `12306069199` as requested.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12306079613

[bhombot-ci[bot]]

@FraserGreenroyd I have now provided a passing check on reference `12306079613` as requested.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci[bot]]

@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge` There are 28 requests in the queue ahead of you.

[FraserGreenroyd]

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

[bhombot-ci[bot]]

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.