BHoM / SAP2000_Toolkit

GNU Lesser General Public License v3.0
9 stars 3 forks source link

Fix beta-code-compliance failures #302

Closed peterjamesnugent closed 5 months ago

peterjamesnugent commented 5 months ago

Issues addressed by this PR

Closes #301

Test files

Changelog

Additional comments

peterjamesnugent commented 5 months ago

@BHoMBot check code-compliance

bhombot-ci[bot] commented 5 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` There are 3 requests in the queue ahead of you.
peterjamesnugent commented 5 months ago

@BHoMBot check required @BHoMBot check compliance

bhombot-ci[bot] commented 5 months ago
@peterjamesnugent to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 3 requests in the queue ahead of you.
bhombot-ci[bot] commented 5 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `22949450241`
FraserGreenroyd commented 5 months ago

@BHoMBot fix project file ref. 22949450241

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd I have queued up your request to fix the `csproj` file(s). There are 5 requests in the queue ahead of you.
bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.
FraserGreenroyd commented 5 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 6 requests in the queue ahead of you.
FraserGreenroyd commented 5 months ago

@BHoMBot check required

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer` There are 14 requests in the queue ahead of you.
bhombot-ci[bot] commented 5 months ago
The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `project-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `versioning` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 5 months ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
FraserGreenroyd commented 5 months ago

@BHoMBot check ready-to-merge

bhombot-ci[bot] commented 5 months ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `ready-to-merge`