BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

Rewrite python components #126

Closed EKAdebo closed 1 year ago

EKAdebo commented 1 year ago

NOTE: Depends on

Issues addressed by this PR

Closes #123

Two python components in the script have been rewritten. They both rename parts of the script, one renames the walls and roofs to be in line with the schema, and the other renames the opening types to be in line with the argyle schema.

Test files

Changelog

Additional comments

EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 2 requests in the queue ahead of you.
EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 1 requests in the queue ahead of you.
EKAdebo commented 1 year ago

@BHoMBot check core @BHoMBot check serialisation

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `core` - check `serialisation` There are 19 requests in the queue ahead of you.