BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

Reinstate PCDB query methods #166

Open rboulton-BH opened 12 months ago

rboulton-BH commented 12 months ago

Description:

Could we please reinstate and expand on the PCDB query methods? These were originally defined and created in issue #35 and PR #39

I have a (non-urgent) project related need to interrogate the database but looks like we have removed the methods in the tidy-up from issue #121 / PR #124

Once the previous methods are reinstated, would be good to add the following functionality:

rboulton-BH commented 12 months ago

Updated PCDB specs: SAP 10 - https://www.ncm-pcdb.org.uk/sap/filelibrary/pdf/PCDB-specification/SAP-10-PRODUCT-CHARACTERISTICS-DATABASE-SPECIFICATION-Issue-1.0.pdf SAP 2012 - https://www.ncm-pcdb.org.uk/sap/filelibrary/pdf/PCDF_Spec_Rev-06b_12_May_2021.pdf

FraserGreenroyd commented 12 months ago

Following discussion on Friday between @rboulton-BH , @JohannaOlin1 , @albinber , and @FraserGreenroyd , decision for @JohannaOlin1 to reinstate the methods @emilsvedjer previously wrote as adapter methods, to avoid adding a lot of components to the UIs but retain the full functionality. This will align with the new adapter methodology for this toolkit introduced this milestone.