Closed adecler closed 1 week ago
@BHoMBot check core @BHoMBot check compliance
@BHoMBot check serialisation
@BHoMBot check installer @BHoMBot check versioning
This PR would fix a different issue with pushing SAP results to excel, so any testing after this point is testing that the change fixes the issue found and doesn't cause other issues. (issue being that the correct version of ClosedXML was missing, and updating to 0.102.2 fixes this)
Closing as the branch name is shared with Excel_Toolkit changes. the new PR is here: #176
NOTE: Related to
Related to this PR: https://github.com/BHoM/Excel_Toolkit/pull/81
Test files
This will first have to be tested in Revit by @pawelbaran to make sure it solved the issue highlighted here: https://github.com/BHoM/Excel_Toolkit/pull/81#pullrequestreview-2148257607
This will then have to be tested to make sure the version change doesn't break the creation of the output results. @rboulton-BH , I hope you can assign someone to do that. I am not familiar with the SAP toolkit so be mindful that I haven't done any testing myself.