BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

Uptick ClosedXML version to 0.102.2 to align with Excel Toolkit and PowerPoint Toolkit #173

Closed adecler closed 1 week ago

adecler commented 4 months ago

NOTE: Related to

Related to this PR: https://github.com/BHoM/Excel_Toolkit/pull/81

Test files

This will first have to be tested in Revit by @pawelbaran to make sure it solved the issue highlighted here: https://github.com/BHoM/Excel_Toolkit/pull/81#pullrequestreview-2148257607

This will then have to be tested to make sure the version change doesn't break the creation of the output results. @rboulton-BH , I hope you can assign someone to do that. I am not familiar with the SAP toolkit so be mindful that I haven't done any testing myself.

Tom-Kingstone commented 1 week ago

@BHoMBot check core @BHoMBot check compliance

bhombot-ci[bot] commented 1 week ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `core` - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
Tom-Kingstone commented 1 week ago

@BHoMBot check serialisation

bhombot-ci[bot] commented 1 week ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `serialisation`
Tom-Kingstone commented 1 week ago

@BHoMBot check installer @BHoMBot check versioning

bhombot-ci[bot] commented 1 week ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `installer` - check `versioning`
Tom-Kingstone commented 1 week ago

This PR would fix a different issue with pushing SAP results to excel, so any testing after this point is testing that the change fixes the issue found and doesn't cause other issues. (issue being that the correct version of ClosedXML was missing, and updating to 0.102.2 fixes this)

bhombot-ci[bot] commented 1 week ago
This repository is not part of the beta package and does not require a versioning check to be performed.
Tom-Kingstone commented 1 week ago

Closing as the branch name is shared with Excel_Toolkit changes. the new PR is here: #176