search

BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

Updated ClosedXML version to 0.102.2 #176

Open Tom-Kingstone opened 4 days ago

Tom-Kingstone commented 4 days ago

Issues addressed by this PR

Closes #175

As in the issue, same change as in #173, but not linked to an excel toolkit PR

Tom-Kingstone commented 4 days ago

@BHoMBot check installer

bhombot-ci[bot] commented 4 days ago
@Tom-Kingstone to confirm, the following actions are now queued: - check `installer`
pawelbaran commented 4 days ago

@Tom-Kingstone, won't we end up with 2 versions of ClosedXML in the BHoM\Assemblies folder? If not, then it should be perfectly fine to decouple from Excel_Toolkit 👍

jamesramsden-bh commented 4 days ago

@BHoMBot check required

bhombot-ci[bot] commented 4 days ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`
bhombot-ci[bot] commented 4 days ago
This repository is not part of the beta package and does not require a versioning check to be performed.
bhombot-ci[bot] commented 4 days ago
The check `installer` has already been run previously and recorded as a successful check. This check has not been run again at this time.
jamesramsden-bh commented 3 days ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 3 days ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `copyright-compliance`
Tom-Kingstone commented 3 days ago

@Tom-Kingstone, won't we end up with 2 versions of ClosedXML in the BHoM\Assemblies folder? If not, then it should be perfectly fine to decouple from Excel_Toolkit 👍

@pawelbaran I'll give it a check using today's alpha installer, and the installer the bot made from this PR, but I think that the problem before is that two different versions of ClosedXML are being targeted currently, and this just aligns the two together. There can't be two ClosedXML.dll files in the assemblies folder, though I don't know how one version is decided over another (maybe compile order?)

To be clear, the version that Excel_Toolkit targets is 0.102.2

Tom-Kingstone commented 3 days ago

I checked with yesterday's alpha, and that installs ClosedXML version 0.102.2 image And the installer for this branch also installs the same version, so it should be ok to merge

pawelbaran commented 3 days ago

All clear @Tom-Kingstone, actually my comment may have been irrelevant from the very beginning - the fact the original PR was linked with the Excel_Toolkit PR raised a flag in my head as I have spent lots of time trying to fix it the other day. However, as you notice, this PR only aligns with what we already have in BHoM, so naturally nothing against it 👍 Thank you and apologies for confusion, if any 🙈