BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

Ventilation objects and XML translations #36

Closed emilsvedjer closed 2 years ago

emilsvedjer commented 2 years ago

NOTE: Depends on

Issues addressed by this PR

Closes #34

Test files

here

Changelog

Additional comments

FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance` There are 1 requests in the queue ahead of you.
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to do? For a list of available instructions, please see [this wiki page](https://github.com/BHoM/documentation/wiki/Continuous-Integration).
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance` There are 4 requests in the queue ahead of you.
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance`
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `4737952844`
FraserGreenroyd commented 2 years ago

@BHoMBot fix copyright headers ref. 4737952844

bhombot-ci[bot] commented 2 years ago
@frasergreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 2 years ago
@frasergreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance`
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance`
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance`
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance` There are 2 requests in the queue ahead of you.
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance`