BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

Execute output to JsonObject and upgraded to NetStandard2.0 #40

Closed emilsvedjer closed 2 years ago

emilsvedjer commented 2 years ago

Issues addressed by this PR

Closes #23

Added json object and put this as output from execute. Upgraded from .NetFramework4.7.2. to .NetStandard2.0

Test files

this file

Additional comments

Ability to query properties using GetProperty method, therefore it closes the linked issue.

FraserGreenroyd commented 2 years ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `project-compliance`
FraserGreenroyd commented 2 years ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `project-compliance`
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `5050482549`
FraserGreenroyd commented 2 years ago

@BHoMBot fix project file ref. 5050482549

bhombot-ci[bot] commented 2 years ago
@frasergreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 2 years ago
@frasergreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.
FraserGreenroyd commented 2 years ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `project-compliance`
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance`