BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

SAP_Toolkit #46 Add template dwelling XML and pushToXML convert method #50

Closed rboulton-BH closed 2 years ago

rboulton-BH commented 2 years ago

Issues addressed by this PR

Closes #46

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/SAP_Toolkit/%2346-templateDwelling-pushToXML.gh?csf=1&web=1&e=DN26lf

Changelog

Additional comments

Doesn't actually work yet, will require audit of SAP2012Data XML definition to ensure correct serialisation

FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance @BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance` - `project-compliance` There are 344 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `6404099208`
FraserGreenroyd commented 2 years ago

@BHoMBot fix copyright headers ref. 6404099208

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd I have queued up your request to fix copyright headers. There are 344 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance @BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance` - `project-compliance` There are 349 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `6404136310`
FraserGreenroyd commented 2 years ago

@BHoMBot fix copyright headers ref. 6404136310

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd I have queued up your request to fix copyright headers. There are 344 requests in the queue ahead of you.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.
FraserGreenroyd commented 2 years ago

@BHoMBot check copyright-compliance @BHoMBot check project-compliance

bhombot-ci[bot] commented 2 years ago
@FraserGreenroyd to confirm, the following checks are now queued: - `copyright-compliance` - `project-compliance` There are 348 requests in the queue ahead of you.