BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

SAP_Toolkit: Defining objects in the SAP Toolkit #64

Closed EKAdebo closed 1 year ago

EKAdebo commented 2 years ago

Defining objects in the SAP Toolkit from the Stroma SAP 10.2 JSON.

Fixes #65

rboulton-BH commented 2 years ago

PR resolves issue #65

FraserGreenroyd commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 9829768541 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 136 additional annotations waiting, made up of 136 errors and 0 warnings.
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 9829779126 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 115 additional annotations waiting, made up of 115 errors and 0 warnings.
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 9829796998 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 22 additional annotations waiting, made up of 22 errors and 0 warnings.
bhombot-ci[bot] commented 1 year ago
@EKAdebo fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `9829786315`
bhombot-ci[bot] commented 1 year ago
@EKAdebo fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `9829786315`
EKAdebo commented 1 year ago

@BHoMBot fix project file ref. 9829786315

bhombot-ci[bot] commented 1 year ago
@EKAdebo I have queued up your request to fix the `csproj` file(s). There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@EKAdebo I am now going to fix the project compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.
EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 9844748387 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 135 additional annotations waiting, made up of 135 errors and 0 warnings.
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 9844753782 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 115 additional annotations waiting, made up of 115 errors and 0 warnings.
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 9844767340 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 23 additional annotations waiting, made up of 23 errors and 0 warnings.
bhombot-ci[bot] commented 1 year ago
@EKAdebo fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `9844767340`
EKAdebo commented 1 year ago

@BHoMBot fix copyright headers ref. 9844767340

bhombot-ci[bot] commented 1 year ago
@EKAdebo I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@EKAdebo I am now going to fix the copyright compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.
EKAdebo commented 1 year ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `copyright-compliance` There are 2 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@EKAdebo fix requested for copyright headers. The errors with the copyright headers on the CS (`.cs`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS (`.cs`) file that does not have the current copyright header will have it applied. The current copyright header can be examined [here](https://github.com/BHoM/BHoM/blob/main/COPYRIGHT_HEADER.txt). If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix copyright headers ref. `9844839106`
EKAdebo commented 1 year ago

@BHoMBot fix copyright headers ref. 9844839106

bhombot-ci[bot] commented 1 year ago
@EKAdebo I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@EKAdebo I am now going to fix the copyright compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.
EKAdebo commented 1 year ago

@BHoMBot check copyright-compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `copyright-compliance`
EKAdebo commented 1 year ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `project-compliance`
jamesramsden-bh commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@jamesramsden-bh to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 1 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 9845375157 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 135 additional annotations waiting, made up of 135 errors and 0 warnings.
bhombot-ci[bot] commented 1 year ago
Please be advised that the check with reference 9845380912 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 115 additional annotations waiting, made up of 115 errors and 0 warnings.
EKAdebo commented 1 year ago

@BHoMBot check core

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `core` There are 9 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@EKAdebo fix requested for adding documentation punctuation. The documentation attributes missing punctuation have been recorded as annotations on the checks tab. I will add a full stop (`.`) to the end of any documentation within the changed files which does not currently end in a suitable piece of punctuation. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix documentation punctuation ref. `9845380912`
EKAdebo commented 1 year ago

@BHoMBot fix documentation punctuation ref. 9845380912

bhombot-ci[bot] commented 1 year ago
@EKAdebo I have queued up your request to fix documentation punctuation. There are 25 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@EKAdebo I am now going to add full stops (`.`) to documentation attributes in accordance with the annotations previously made.
bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm I have now resolved the documentation punctuation and pushed a commit to this Pull Request.
FraserGreenroyd commented 1 year ago

@BHoMBot check project-compliance @BHoMBot check copyright-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd to confirm, the following actions are now queued: - check `project-compliance` - check `copyright-compliance`