BHoM / SAP_Toolkit

GNU Lesser General Public License v3.0
4 stars 2 forks source link

Define and update SAP10 XML objects #69

Closed EKAdebo closed 1 year ago

EKAdebo commented 1 year ago

Issues addressed by this PR

Closes #67

The XML objects definitions have been updated to match the new SAP10 XML schema as mentioned in #67, the BHoM object definitions have also been updated, along with the convert methods between these. The examples that were provided in #67 are pulled through without any error that I can see.

EKAdebo commented 1 year ago

@BHoMBot check project-compliance

EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 18 requests in the queue ahead of you.
EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 1 year ago
FAO: @FraserGreenroyd @EKAdebo is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is branch-compliance. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `12258702904`
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12258702904

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have now provided a passing check on reference `12258702904` as requested.
bhombot-ci[bot] commented 1 year ago
@EKAdebo dispensation cannot be requested for a check with ref. 12258706433 because it has already concluded to neutral, which indicates the check is not required in this situation.
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am requesting that you force check: dataset-compliance

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.
bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have provided force checks to the checks requested.
EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
EKAdebo commented 1 year ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `project-compliance` There are 10 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@EKAdebo fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `12428450334`
EKAdebo commented 1 year ago

@BHoMBot fix project file ref. 12428450334

bhombot-ci[bot] commented 1 year ago
@EKAdebo I have queued up your request to fix the `csproj` file(s). There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 1 year ago
@EKAdebo I am now going to fix the project compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.
EKAdebo commented 1 year ago

@BHoMBot check project-compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `project-compliance`
EKAdebo commented 1 year ago

@BHoMBot check compliance

bhombot-ci[bot] commented 1 year ago
@EKAdebo to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
bhombot-ci[bot] commented 1 year ago
The check `project-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.
bhombot-ci[bot] commented 1 year ago
FAO: @FraserGreenroyd @EKAdebo is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate. The check they wish to have dispensation on is branch-compliance. If you are providing dispensation on this occasion, please reply with: > @BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. `12503260482`
FraserGreenroyd commented 1 year ago

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12503260482

bhombot-ci[bot] commented 1 year ago
@FraserGreenroyd I have now provided a passing check on reference `12503260482` as requested.