search

BHoM / Speckle_Toolkit

GNU Lesser General Public License v3.0
10 stars 2 forks source link

Fixed bug that prevented send of customObjects #82

Closed alelom closed 4 years ago

alelom commented 4 years ago

Issues addressed by this PR

Closes #77 Closes #83

Fixes simple bug that prevented the send of CustomObjects. It was an incorrectly named fallback case, plus a catch for empty CompositeGeometry.

Test files

Just try to push a CustomObject as in #77.

al-fisher commented 4 years ago

Hey @alelom - as mentioned Push CustomObject is now working! Pull is giving strange behaviour though image

alelom commented 4 years ago

In order to avoid that the Hash generated for CustomObject remains always the same (due to the fact that we are ignoring CustomData when generating it, and all of the properties of a CustomObject are in CustomData) we need to remove the field from the default values of BH.oM.DiffConfig. Opening separate PR.

alelom commented 4 years ago

@al-fisher with https://github.com/BHoM/BHoM/pull/846, the CustomObject will be uploaded correctly every time a push is done.

The other issue (geometry error when nested CustomObject are input) is solved in the previous commit (https://github.com/BHoM/Speckle_Toolkit/pull/82/commits/1a119b3278e59cd2a062c3500e0aa5653b6c235a).

al-fisher commented 4 years ago

As per image

al-fisher commented 4 years ago

@rwemay FYI