NUnit_Engine: running methods extended and bugfixed

[pawelbaran]

Issues addressed by this PR

Closes #435 Closes #436

Test files

To be added.

Changelog

Additional comments

Not ideal to mix bug + feature, but this is a result of a wider exploration. Happy to split into separate PRs before merging along with targeted test scripts being added.

[pawelbaran]

Thanks @FraserGreenroyd for having a look.

Regarding the addition of RunTests that takes a collection of strings, please note I kept the overload with a single assembly path input, but added the ability to specify classes to test. Hopefully this will not break the bot, and if it does, then happy to bring the original setup back.

When it comes to serialisation, the code on develop struggles on deserialisation of collections in my cases, so I simply made it work. I have absolutely zero opinion on the design of the code here, my only need is to pass the information from XML to test result, so happy for you to take over the steering wheel. But probs best through it together - will schedule a call in the coming days 👍

[FraserGreenroyd]

I also don't like the changing of the XML Properties around Settings and Properties

I have reviewed this with @pawelbaran today and gone through some more tests, I now understand better why this change came in, and am happy with the change being made/kept as it does better support our workflows. Thanks @pawelbaran for being patient and working with me on this 😄

[pawelbaran]

I think we are ready for re-review @FraserGreenroyd 👍

[pawelbaran]

@BHoMBot check required

[bhombot-ci[bot]]

@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`

[bhombot-ci[bot]]

This repository is not part of the beta package and does not require a versioning check to be performed.

[bhombot-ci[bot]]

This repository is not part of the installer package, and does not require an installer check.

[pawelbaran]

@FraserGreenroyd, there are some compliance checks failing, but none of the failures got introduced by this PR I think - are you fine with dispensating?

[FraserGreenroyd]

@FraserGreenroyd, there are some compliance checks failing, but none of the failures got introduced by this PR I think - are you fine with dispensating?

Ordinarily I would agree, however, the project-compliance failures are new following our change from C:/ProgramData to $(ProgramData) and are only being picked up on a PR by PR basis - you can use the bot to fix the project file and that should resolve those suitably.

For the documentation compliance - it is that you have an input attribute that doesn't match any input parameters (filePath instead of the param filePaths) so I would suggest we resolve that one.

[pawelbaran]

@BHoMBot check project compliance

[bhombot-ci[bot]]

@pawelbaran sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to do? For a list of available instructions, please see [this wiki page](https://github.com/BHoM/documentation/wiki/Continuous-Integration).

[pawelbaran]

For the documentation compliance - it is that you have an input attribute that doesn't match any input parameters (filePath instead of the param filePaths) so I would suggest we resolve that one.

Yeah ofc. Not sure how did I read the test results 🤦 Thanks @FraserGreenroyd

[pawelbaran]

@BHoMBot check project-compliance

[bhombot-ci[bot]]

@pawelbaran to confirm, the following actions are now queued: - check `project-compliance` There are 34 requests in the queue ahead of you.

[bhombot-ci[bot]]

@pawelbaran fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `13751724291`

[pawelbaran]

@BHoMBot fix project file ref. 13751724291

[bhombot-ci[bot]]

@pawelbaran I have queued up your request to fix the `csproj` file(s). There are 0 requests in the queue ahead of you.

[bhombot-ci[bot]]

@pawelbaran I am now going to fix the project compliance in accordance with the annotations previously made.

[bhombot-ci[bot]]

@pawelbaran to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci[bot]]

@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` There are 2 requests in the queue ahead of you.

[pawelbaran]

@BHoMBot check required

[bhombot-ci[bot]]

@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `core` - check `null-handling` - check `serialisation` - check `versioning` - check `installer`

[bhombot-ci[bot]]

The check `code-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci[bot]]

The check `documentation-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci[bot]]

The check `project-compliance` has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci[bot]]

This repository is not part of the beta package and does not require a versioning check to be performed.

[bhombot-ci[bot]]

This repository is not part of the installer package, and does not require an installer check.