BHoM / Test_Toolkit

GNU Lesser General Public License v3.0
0 stars 0 forks source link

Kellerman replaced with Diffing #474

Closed pawelbaran closed 6 months ago

pawelbaran commented 6 months ago

NOTE: Depends on

https://github.com/BHoM/BHoM_Engine/pull/3338

Issues addressed by this PR

Closes #473

Test files

Not entirely sure how to test, I did check if geometry UTs run the same as on main, file uploaded on SharePoint. Will also run unit-tests check, happy for recommendations concerning any further testing.

Changelog

Additional comments

I made sure the removed methods were not used anywhere outside of this repo by reviewing the results of following queries: https://github.com/search?q=org%3ABHoM%20isequal&type=code https://github.com/search?q=org%3ABurohappoldengineering%20isequal&type=code https://github.com/search?q=org%3ABHoM%20DifferentProperties&type=code https://github.com/search?q=org%3ABurohappoldengineering%20DifferentProperties&type=code

pawelbaran commented 6 months ago

@BHoMBot check compliance @BHoMBot check core

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance` - check `core`
bhombot-ci[bot] commented 6 months ago
@pawelbaran fix requested for project compliance. The errors with the CSProject (`.csproj`) files have been recorded as annotations on the checks tab. I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with: > @BHoMBot fix project file ref. `24298883442`
pawelbaran commented 6 months ago

@BHoMBot fix project file ref. 24298883442

bhombot-ci[bot] commented 6 months ago
@pawelbaran I have queued up your request to fix the `csproj` file(s). There are 0 requests in the queue ahead of you.
bhombot-ci[bot] commented 6 months ago
@pawelbaran I am now going to fix the project compliance in accordance with the annotations previously made.
bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.
pawelbaran commented 6 months ago

@BHoMBot check compliance

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `code-compliance` - check `documentation-compliance` - check `project-compliance` - check `branch-compliance` - check `dataset-compliance` - check `copyright-compliance`
pawelbaran commented 6 months ago

@BHoMBot check null-handling @BHoMBot check serialisation

bhombot-ci[bot] commented 6 months ago
@pawelbaran to confirm, the following actions are now queued: - check `null-handling` - check `serialisation` There are 30 requests in the queue ahead of you.