search

BHoM / Versioning_Toolkit

GNU Lesser General Public License v3.0
0 stars 2 forks source link

Not all types and methods from 3.3 are versioning correctly #110

Closed adecler closed 3 years ago

adecler commented 3 years ago

Description:

See comments below for failing types and methods

Steps to reproduce:

I'll soon provide the dataset containing objects and methods from previous beta as well as the scripts needed to do the testing.

Expected behaviour:

All objects and methods from previous betas should deserialise correctly

Test file(s):

adecler commented 3 years ago

Failing items from beta 3.3

Failing objects (returning null)

``` ```

Failing objects (returning CustomObject)

```c# BH.oM.Adapter.ActionConfig BH.oM.Adapter.Mongo.MongoConfig BH.oM.Adapters.CarbonQueryDatabase.CQDConfig BH.oM.Adapters.ETABS.Fragments.EtabsLabel BH.oM.Adapters.Filing.ExecuteConfig BH.oM.Adapters.Filing.PullConfig BH.oM.Adapters.Filing.PushConfig BH.oM.Adapters.Filing.RemoveConfig BH.oM.Adapters.GSA.GSAConfig BH.oM.Adapters.HTTP.HTTPConfig BH.oM.Adapters.iAuditor.iAuditorConfig BH.oM.Adapters.Revit.Elements.ViewPlan BH.oM.Adapters.Revit.Generic.FamilyLibrary BH.oM.Adapters.Revit.Generic.RevitFilePreview BH.oM.Adapters.Revit.RevitPullConfig BH.oM.Adapters.Revit.RevitPushConfig BH.oM.Adapters.Revit.RevitRemoveConfig BH.oM.Adapters.Revit.Settings.FamilyLoadSettings BH.oM.Adapters.Revit.Settings.RevitSettings BH.oM.Adapters.SAP2000.SAP2000ActionConfig BH.oM.Adapters.XML.XMLConfig BH.oM.Diffing.Delta BH.oM.Diffing.Diff BH.oM.Diffing.DiffConfig BH.oM.Diffing.HashFragment BH.oM.Diffing.Revision BH.oM.Graphics.RenderMeshOptions BH.oM.LifeCycleAssessment.EnclosuresScope BH.oM.LifeCycleAssessment.FoundationsScope BH.oM.LifeCycleAssessment.MaterialFragments.EnvironmentalProductDeclaration BH.oM.LifeCycleAssessment.MaterialFragments.SectorEnvironmentalProductDeclaration BH.oM.LifeCycleAssessment.MEPScope BH.oM.LifeCycleAssessment.ProjectLifeCycleAssessment BH.oM.LifeCycleAssessment.Results.GlobalWarmingPotentialResult BH.oM.LifeCycleAssessment.Results.LifeCycleAssessmentResult BH.oM.LifeCycleAssessment.StructuresScope BH.oM.LifeCycleAssessment.TenantImprovementScope BH.oM.MEP.Elements.Duct BH.oM.MEP.Elements.FlowSystem BH.oM.MEP.Elements.Node BH.oM.MEP.Elements.Pipe BH.oM.MEP.Elements.Wire BH.oM.MEP.Elements.WireSegment BH.oM.MEP.FireProtection BH.oM.MEP.Results.MEPSystemResults BH.oM.MEP.SectionProperties.DuctSectionProperty BH.oM.MEP.SectionProperties.PipeSectionProperty BH.oM.MEP.SectionProperties.WireSectionProperty BH.oM.PerformanceDashboard.AccreditationBREEAM BH.oM.PerformanceDashboard.AccreditationWELL BH.oM.PerformanceDashboard.Address BH.oM.PerformanceDashboard.EmbodiedCarbon BH.oM.PerformanceDashboard.EnergyMeasured BH.oM.PerformanceDashboard.EnergyModelled BH.oM.PerformanceDashboard.Meter BH.oM.PerformanceDashboard.NetZeroCarbon BH.oM.PerformanceDashboard.Record BH.oM.Reflection.Attributes.InputAttribute BH.oM.Reflection.Attributes.MultiOutputAttribute BH.oM.Reflection.Attributes.OutputAttribute BH.oM.Structure.Loads.BarVaryingDistributedLoad BH.oM.Structure.MaterialFragments.GenericIsotropicMaterial ```

Failing methods

``` BH.Engine.Adapters.CarbonQueryDatabase.Create.CarbonQueryDatabaseRequest BH.Engine.Adapters.DIALux.Convert.ToDialUX BH.Engine.Adapters.DIALux.Convert.ToDIALux BH.Engine.Adapters.IES.Modify.RoundedPoint BH.Engine.Adapters.TAS.Create.BHoMObject BH.Engine.Adapters.TAS.Create.BuildingElement BH.Engine.Adapters.TAS.Modify.UpdateCustomDataValue BH.Engine.Adapters.TAS.Query.IsExternal BH.Engine.Adapters.TAS.Query.SurfaceType BH.Engine.Adapters.XML.Create.XMLSettings BH.Engine.Architecture.Modify.SetGeometry BH.Engine.Base.Compute.Hash BH.Engine.Base.Query.TryGetValue BH.Engine.BuildingEnvironment.Convert.ToConstruction BH.Engine.BuildingEnvironment.Convert.ToGasMaterial BH.Engine.BuildingEnvironment.Convert.ToLayer BH.Engine.BuildingEnvironment.Convert.ToMaterial BH.Engine.BuildingEnvironment.Convert.ToSolidMaterial BH.Engine.ClimateEmergency.Compute.PlumbingFixtureWaterDemandPerDay BH.Engine.ClimateEmergency.Create.BuildingOccupancyByGender BH.Engine.ClimateEmergency.Create.BuildingPlumbingFixtureSelection BH.Engine.Diffing.Compute.DiffGenericObjects BH.Engine.Diffing.Compute.Diffing BH.Engine.Diffing.Compute.DiffingHash BH.Engine.Diffing.Compute.DiffOneByOne BH.Engine.Diffing.Compute.DiffRevisions BH.Engine.Diffing.Compute.DiffWithCustomId BH.Engine.Diffing.Compute.DiffWithFragmentId BH.Engine.Diffing.Create.DiffConfig BH.Engine.Diffing.Modify.PrepareForRevision BH.Engine.Diffing.Modify.RemoveDuplicatesByHash BH.Engine.Diffing.Modify.SetHashFragment BH.Engine.Diffing.Query.AnyDuplicateByHash BH.Engine.Diffing.Query.DifferentProperties BH.Engine.Diffing.Query.GetHashFragment BH.Engine.Environment.Create.Layer BH.Engine.Environment.Modify.UpdatePanelTypeByCustomData BH.Engine.LifeCycleAssessment.Compute.EvaluateEnvironmentalProductDeclarationByArea BH.Engine.LifeCycleAssessment.Compute.EvaluateEnvironmentalProductDeclarationByMass BH.Engine.LifeCycleAssessment.Compute.EvaluateEnvironmentalProductDeclarationByVolume BH.Engine.LifeCycleAssessment.Compute.MaterialEndOfLifeTreatment BH.Engine.MachineLearning.Compute.Infer BH.Engine.MachineLearning.Compute.InferInverse BH.Engine.MachineLearning.Compute.InstallMachineLearningToolkit BH.Engine.MachineLearning.Compute.Invoke BH.Engine.MachineLearning.Compute.InvokeNumpy BH.Engine.MachineLearning.Compute.LinearRegression BH.Engine.MachineLearning.Compute.LoadCsv BH.Engine.MachineLearning.Compute.MinMaxScaler BH.Engine.MachineLearning.Compute.PolynomialFeatures BH.Engine.MachineLearning.Compute.StandardScaler BH.Engine.MEP.Modify.SetGeometry BH.Engine.MEP.Query.EquipmentLengthByPart BH.Engine.PerformanceDashboard.Create.Space BH.Engine.PerformanceDashboard.Query.Summary BH.Engine.Python.Query.TryImport BH.Engine.Reflection.Modify.PropertyValue BH.Engine.Reflection.Modify.SetPropertyValue BH.Engine.Representation.Modify.SetRendermesh BH.Engine.Representation.Query.TryGetRendermesh BH.Engine.Structure.Query.HasAssignedObjectIds BH.Engine.Structure.Results.Query.MapResults BH.Engine.Vision.Compute.DetectObjects BH.Engine.Vision.Compute.DrawDetection ```

adecler commented 3 years ago

The list of objects from 3.3 that are completely failing (returning null) is now confirmed to be empty (once I push my fixes on teh Serialiser and Versioning toolkit).

On the other hand, there seems to be a decent number of objects types that return a CustomObject. This means that those were not provided versioning. I have manually checked a few of them and all of them are indeed missing the required versioning info in the Upgrade.json file.

IsakNaslundBh commented 3 years ago

To speak for the items in the lists that I or people in structures have changed:

Objects

BH.oM.Structure.MaterialFragments.GenericIsotropicMaterial - Typo in versioning TK. PR raised, should be working

BH.oM.Structure.Loads.BarVaryingDistributedLoad - New version might need to turn one obejct into multiple due to redefinition of some properties. This is not yet supported as far as I know, so will have to live with this failure for now. Change was to important to leave it hanging.

BH.oM.Adapters.ETABS.Fragments.EtabsLabel Has a versioning file applied to it. Will investigate what is going on here.

Methods:

Made private:
BH.Engine.Geometry.Create.AngleProfileCurves
BH.Engine.Geometry.Create.BoxProfileCurves
BH.Engine.Geometry.Create.ChannelProfileCurves
BH.Engine.Geometry.Create.CircleProfileCurves
BH.Engine.Geometry.Create.FabricatedBoxProfileCurves
BH.Engine.Geometry.Create.GeneralisedFabricatedBoxProfileCurves
BH.Engine.Geometry.Create.GeneralisedTeeProfileCurves
BH.Engine.Geometry.Create.IProfileCurves
BH.Engine.Geometry.Create.KiteProfileCurves
BH.Engine.Geometry.Create.RectangleProfileCurves
BH.Engine.Geometry.Create.TeeProfileCurves
BH.Engine.Geometry.Create.TubeProfileCurves
BH.Engine.Geometry.Create.ZSectionProfile

The methods above where just support methods for generating geometry for the profiles. Them showing up in the UI was mostly just an annoyance, so made the decision together with @al-fisher @peterjamesnugent and @JosefTaylor to make them private.

BH.Engine.Adapters.ETABS.Convert.ToCSI
BH.Engine.Adapters.ETABS.Convert.ToDoubleArray
BH.Engine.Adapters.ETABS.Convert.ToVector

Inner convert methods, moved to the adapter.

Deleted:
BH.Engine.Structure.Create.NewElement0D
BH.Engine.Structure.Create.NewElement1D

Both methods where marked as to be removed in 3.2. They also have no use in the UI and was only added as they previously filled a big role in the inner works of the IElementXD patterns. That pattern was changed in 3.2, so feel safe to remove them now.

BH.Engine.Adapters.ETABS.Compute.UpgradeVersion

Still there, unchanged, but Deprecated since 3.1. Will delete the method next milestone

BH.Engine.Adapters.Robot.Compute.GroupBarsByLength

Method used for inner workings of the adapter, no longer required.

To be investigated:
BH.Engine.Structure.Query.HasAssignedObjectIds
BH.Engine.Structure.Results.Query.MapResults

Both these should arguably be working. Will check what has happened here (in case no versioning has been added).

pawelbaran commented 3 years ago

Thanks @adecler for preparing the lists. I summarized the Revit_Toolkit-related issues below.

Failing objects:

Failing methods:

@alelom could you please look into the issues with ActionConfig this can spill across the whole BHoM 🙈

alelom commented 3 years ago

@alelom could you please look into the issues with ActionConfig this can spill across the whole BHoM 🙈

@pawelbaran it should be fixed by this https://github.com/BHoM/BHoM_Adapter/pull/272

pawelbaran commented 3 years ago

@IsakNaslundBh I have just noticed GenericIsotropicMaterial does not deserialize correctly even after rebuilding Versioning_Toolkit:

image

The snip above comes from one of the 3.3 scripts. Do you have an idea what could happen there?

EDIT: that has been fixed in one of the late Versioning_Toolkit PRs, the issue disappeared after full rebuild from master.

adecler commented 3 years ago

all other methods were deleted as deprecated/legacy in this and this commit

Thanks @pawelbaran . Can you list those method here explicitly so I can make sure the correct methods are added to the exception ?

pawelbaran commented 3 years ago

@adecler, following methods were deprecated and subsequently deleted:

BH.Engine.Adapters.Revit.Create.BHoMObject
BH.Engine.Adapters.Revit.Create.Panel
BH.Engine.Adapters.Revit.Modify.SetFamilyLibrary
BH.Engine.Adapters.Revit.Modify.SetFamilyName
BH.Engine.Adapters.Revit.Modify.SetFamilyTypeName
BH.Engine.Adapters.Revit.Modify.SetMapSettings
BH.Engine.Adapters.Revit.Modify.UpdateCustomDataValue
BH.Engine.Adapters.Revit.Query.AdjacentSpaceId
BH.Engine.Adapters.Revit.Query.CustomDataValue
BH.Engine.Adapters.Revit.Query.Duplicate
BH.Engine.Adapters.Revit.Query.FamilyPlacementTypeName
BH.Engine.Adapters.Revit.Query.FilterByType
BH.Engine.Adapters.Revit.Query.IsAssignableFromByFullName
BH.Engine.Adapters.Revit.Query.IsTemplate
BH.Engine.Adapters.Revit.Query.IsZero
BH.Engine.Adapters.Revit.Query.Location
BH.Engine.Adapters.Revit.Query.MapSettings
BH.Engine.Adapters.Revit.Query.SheetNumber
BH.Engine.Adapters.Revit.Query.SpaceId
BH.Engine.Adapters.Revit.Query.UniqueIds
BH.Engine.Adapters.Revit.Query.ViewName
BH.Engine.Adapters.Revit.Query.WorksetId

Method that is meant to break to inform the user that breaking changes were introduced:

BH.Engine.Adapters.Revit.Create.ViewPlan

Method that did not exist in 3.3:

BH.Engine.Adapters.Revit.Create.BuildingElement

Out of curiosity, I did investigate the above, there was a Create file named BuildingElement.cs, but it has been renamed and method refactored a long time ago. So I have no clue how did you catch it @adecler 😃

adecler commented 3 years ago

Thanks @pawelbaran . I have added those exceptions to the PR: https://github.com/BHoM/Versioning_Toolkit/pull/116

adecler commented 3 years ago

Failing items from beta 3.2

Failing objects (returning null)

``` ```

Failing objects (returning CustomObject)

```c# BH.oM.Adapter.ActionConfig BH.oM.Adapter.CarbonQueryDatabase.CQDConfig BH.oM.Adapter.Mongo.MongoConfig BH.oM.Adapter.Sharepoint.SharepointConfig BH.oM.Adapters.DIALux.Furnishing BH.oM.Adapters.DIALux.Luminaire BH.oM.Adapters.DIALux.LuminaireType BH.oM.Adapters.DIALux.Project BH.oM.Adapters.DIALux.Room BH.oM.Adapters.DIALux.StfFile BH.oM.Adapters.DIALux.Structure BH.oM.Adapters.DIALux.Version BH.oM.Adapters.ETABS.Fragments.EtabsLabel BH.oM.Adapters.GSA.GSAConfig BH.oM.Adapters.Revit.Elements.ViewPlan BH.oM.Adapters.Revit.Generic.RevitFilePreview BH.oM.Adapters.Revit.RevitPullConfig BH.oM.Adapters.Revit.RevitPushConfig BH.oM.Adapters.Revit.RevitRemoveConfig BH.oM.Adapters.SAP2000.SAP2000ActionConfig BH.oM.Adapters.XML.GBXMLDocumentBuilder BH.oM.Adapters.XML.XMLConfig BH.oM.Architecture.Elements.Ceiling BH.oM.Climate.Schedule BH.oM.CSharp.Variable BH.oM.Data.Collections.Graph`1[[System.Object, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]], Data_oM, Version=3.0.0.0, Culture=neutral, PublicKeyToken=null BH.oM.Diffing.Delta BH.oM.Diffing.Diff BH.oM.Diffing.DiffConfig BH.oM.Diffing.HashFragment BH.oM.Diffing.Revision BH.oM.Environment.Elements.Opening BH.oM.Environment.Elements.Panel BH.oM.Environment.Elements.Space BH.oM.Environment.Gains.Equipment BH.oM.Environment.Gains.Infiltration BH.oM.Environment.Gains.Lighting BH.oM.Environment.Gains.People BH.oM.Environment.Gains.Plug BH.oM.Environment.Gains.Pollutant BH.oM.Environment.Gains.Profile BH.oM.Environment.Gains.Thermostat BH.oM.Excel.Rectangle BH.oM.Excel.Reference BH.oM.Filing.Directory BH.oM.Filing.File BH.oM.Filing.FilingConfig BH.oM.Graphics.RenderMeshOptions BH.oM.HTTP.HTTPConfig BH.oM.LifeCycleAssessment.EnclosuresScope BH.oM.LifeCycleAssessment.FoundationsScope BH.oM.LifeCycleAssessment.LifeCycleAssessmentScope BH.oM.LifeCycleAssessment.MaterialFragments.EnvironmentalProductDeclaration BH.oM.LifeCycleAssessment.MaterialFragments.SectorEnvironmentalProductDeclaration BH.oM.LifeCycleAssessment.MEPScope BH.oM.LifeCycleAssessment.ProjectLifeCycleAssessment BH.oM.LifeCycleAssessment.Results.GlobalWarmingPotentialResult BH.oM.LifeCycleAssessment.Results.LifeCycleAssessmentResult BH.oM.LifeCycleAssessment.StructuresScope BH.oM.LifeCycleAssessment.TenantImprovementScope BH.oM.MEP.Elements.Conduit BH.oM.MEP.Elements.Duct BH.oM.MEP.Elements.Node BH.oM.MEP.Elements.Pipe BH.oM.MEP.FireProtection BH.oM.MEP.MaterialFragments.SomeMaterial BH.oM.MEP.Results.MEPSystemResults BH.oM.MEP.SectionProperties.ExplicitProperty BH.oM.MEP.SectionProperties.SectionProperty BH.oM.MEP.SurfaceProperties.ConstantThickness BH.oM.Physical.Constructions.Construction BH.oM.Physical.Constructions.Layer BH.oM.Physical.Elements.Beam BH.oM.Physical.Elements.Bracing BH.oM.Physical.Elements.Cable BH.oM.Physical.Elements.Column BH.oM.Physical.Elements.Floor BH.oM.Physical.Elements.Pile BH.oM.Physical.Elements.Roof BH.oM.Physical.Elements.Wall BH.oM.Physical.FramingProperties.ConstantFramingProperty BH.oM.Physical.Materials.Material BH.oM.Physical.Reinforcement.PrimaryReinforcingBar BH.oM.Physical.Reinforcement.ReinforcementFragment BH.oM.Physical.Reinforcement.Stirrup BH.oM.Radiance.Parameters.DctimestepParameters BH.oM.Radiance.Parameters.GendaymtxParameters BH.oM.Radiance.Parameters.GenskyParameters BH.oM.Radiance.Parameters.OconvParameters BH.oM.Radiance.Parameters.RcalcParameters BH.oM.Radiance.Parameters.RcontribParameters BH.oM.Radiance.Parameters.RfluxmtxParameters BH.oM.Radiance.Parameters.RmtxopParameters BH.oM.Radiance.Parameters.RtraceParameters BH.oM.Radiance.Polygon BH.oM.Radiance.Results BH.oM.Reflection.Attributes.InputAttribute BH.oM.Reflection.Attributes.MultiOutputAttribute BH.oM.Reflection.Attributes.OutputAttribute BH.oM.Sharepoint.Library BH.oM.Sharepoint.Requests.AndCondition BH.oM.Sharepoint.Requests.BeginsWithCondition BH.oM.Sharepoint.Requests.ContainsCondition BH.oM.Sharepoint.Requests.EqualCondition BH.oM.Sharepoint.Requests.GreaterCondition BH.oM.Sharepoint.Requests.GreaterEqualCondition BH.oM.Sharepoint.Requests.LessCondition BH.oM.Sharepoint.Requests.LessEqualCondition BH.oM.Sharepoint.Requests.NotEqualCondition BH.oM.Sharepoint.Requests.OrCondition BH.oM.Sharepoint.Requests.SharepointRequest BH.oM.Structure.Bridges.Ladder BH.oM.Structure.Buildings.MultiStorey BH.oM.Structure.Elements.BowlStructure BH.oM.Structure.Loads.BarVaryingDistributedLoad BH.oM.Structure.SectionProperties.CompositeSection BH.oM.Structure.SectionProperties.ConcreteSection BH.oM.TAS.Settings.TASSettings GraphLink`1 GraphNode`1 ```

Failing methods

``` BH.Engine.Adapters.DIALux.Convert.ToDialUX BH.Engine.Adapters.DIALux.Convert.ToDIALux BH.Engine.Adapters.ETABS.Compute.UpgradeVersion BH.Engine.Adapters.ETABS.Convert.ToCSI BH.Engine.Adapters.ETABS.Convert.ToDoubleArray BH.Engine.Adapters.ETABS.Convert.ToVector BH.Engine.Adapters.IES.Modify.RoundedPoint BH.Engine.Adapters.Revit.Create.BHoMObject BH.Engine.Adapters.Revit.Create.BuildingElement BH.Engine.Adapters.Revit.Create.Panel BH.Engine.Adapters.Revit.Create.ViewPlan BH.Engine.Adapters.Revit.Modify.SetFamilyLibrary BH.Engine.Adapters.Revit.Modify.SetFamilyName BH.Engine.Adapters.Revit.Modify.SetFamilyTypeName BH.Engine.Adapters.Revit.Modify.SetMapSettings BH.Engine.Adapters.Revit.Modify.UpdateCustomDataValue BH.Engine.Adapters.Revit.Query.AdjacentSpaceId BH.Engine.Adapters.Revit.Query.CustomDataValue BH.Engine.Adapters.Revit.Query.Duplicate BH.Engine.Adapters.Revit.Query.FamilyPlacementTypeName BH.Engine.Adapters.Revit.Query.FilterByType BH.Engine.Adapters.Revit.Query.IsAssignableFromByFullName BH.Engine.Adapters.Revit.Query.IsTemplate BH.Engine.Adapters.Revit.Query.IsZero BH.Engine.Adapters.Revit.Query.Location BH.Engine.Adapters.Revit.Query.MapSettings BH.Engine.Adapters.Revit.Query.SheetNumber BH.Engine.Adapters.Revit.Query.SpaceId BH.Engine.Adapters.Revit.Query.UniqueIds BH.Engine.Adapters.Revit.Query.ViewName BH.Engine.Adapters.Revit.Query.WorksetId BH.Engine.Adapters.Robot.Compute.GroupBarsByLength BH.Engine.Adapters.TAS.Convert.FromTAS BH.Engine.Adapters.TAS.Convert.FromTASOpening BH.Engine.Adapters.TAS.Create.BHoMObject BH.Engine.Adapters.TAS.Create.BuildingElement BH.Engine.Adapters.TAS.Modify.UpdateCustomDataValue BH.Engine.Adapters.TAS.Query.IsExternal BH.Engine.Adapters.TAS.Query.SurfaceType BH.Engine.Adapters.XML.Create.XMLSettings BH.Engine.Architecture.Modify.SetGeometry BH.Engine.Base.Query.TryGetValue BH.Engine.BuildingEnvironment.Convert.ToConstruction BH.Engine.BuildingEnvironment.Convert.ToGasMaterial BH.Engine.BuildingEnvironment.Convert.ToLayer BH.Engine.BuildingEnvironment.Convert.ToMaterial BH.Engine.BuildingEnvironment.Convert.ToSolidMaterial BH.Engine.BuildingEnvironment.Modify.Modify.SetGeometry BH.Engine.BuildingEnvironment.Query.Geometry BH.Engine.BuildingEnvironment.Query.Length BH.Engine.CarbonQueryDatabase.Create.CarbonQueryDatabaseRequest BH.Engine.Climate.Compute.SaturationVaporPressureWater BH.Engine.Climate.Create.AnnualSchedule BH.Engine.Climate.Modify.TransposeRectangularCollection BH.Engine.ClimateEmergency.Compute.PlumbingFixtureWaterDemandPerDay BH.Engine.ClimateEmergency.Create.BuildingOccupancyByGender BH.Engine.ClimateEmergency.Create.BuildingPlumbingFixtureSelection BH.Engine.Data.Query.Children BH.Engine.Data.Query.ItemsInRange BH.Engine.Data.Query.Values BH.Engine.Diffing.Compute.Diffing BH.Engine.Diffing.Compute.DiffingHash BH.Engine.Diffing.Compute.SHA256Hash BH.Engine.Diffing.Convert.ToDiffingByteArray BH.Engine.Diffing.Convert.ToDiffingJson BH.Engine.Diffing.Create.Delta BH.Engine.Diffing.Create.DiffConfig BH.Engine.Diffing.Create.Revision BH.Engine.Diffing.Modify.PrepareForDiffing BH.Engine.Diffing.Modify.RemoveDuplicatesByHash BH.Engine.Diffing.Modify.SetHashFragment BH.Engine.Diffing.Query.AnyDuplicateByHash BH.Engine.Diffing.Query.DifferentProperties BH.Engine.Diffing.Query.GetHashFragment BH.Engine.Diffing.Query.ListModifiedProperties BH.Engine.Environment.Convert.ToDegrees BH.Engine.Environment.Convert.ToRadians BH.Engine.Environment.Create.Building BH.Engine.Environment.Create.BuildingAnalyticalFragment BH.Engine.Environment.Create.BuildingContextFragment BH.Engine.Environment.Create.BuildingResultFragment BH.Engine.Environment.Create.CoefficientFragment BH.Engine.Environment.Create.Edge BH.Engine.Environment.Create.EnvironmentConstructionFragment BH.Engine.Environment.Create.Equipment BH.Engine.Environment.Create.GasMaterial BH.Engine.Environment.Create.Infiltration BH.Engine.Environment.Create.Layer BH.Engine.Environment.Create.Lighting BH.Engine.Environment.Create.LightReflectanceFragment BH.Engine.Environment.Create.LightTransmittanceFragment BH.Engine.Environment.Create.Location BH.Engine.Environment.Create.Opening BH.Engine.Environment.Create.OriginContextFragment BH.Engine.Environment.Create.Panel BH.Engine.Environment.Create.PanelAnalyticalFragment BH.Engine.Environment.Create.PanelContextFragment BH.Engine.Environment.Create.People BH.Engine.Environment.Create.Plug BH.Engine.Environment.Create.Pollutant BH.Engine.Environment.Create.ProfileResult BH.Engine.Environment.Create.RadiationFragment BH.Engine.Environment.Create.SimulationResult BH.Engine.Environment.Create.SolidMaterial BH.Engine.Environment.Create.Space BH.Engine.Environment.Create.SpaceAnalyticalFragment BH.Engine.Environment.Create.SpaceContextFragment BH.Engine.Environment.Create.SpaceTime BH.Engine.Environment.Modify.UpdatePanelTypeByCustomData BH.Engine.Environment.Query.CullOverlaps BH.Engine.Environment.Query.PointsMatch BH.Engine.Environment.Query.ResultsByResultType BH.Engine.Environment.Query.ResultsByType BH.Engine.Environment.Query.ResultsByTypeUnit BH.Engine.Environment.Query.ResultsByTypeUnitResultType BH.Engine.Environment.Query.ResultsByUnit BH.Engine.Environment.Query.UniqueConstructionName BH.Engine.Environment.Query.UniqueConstructions BH.Engine.Excel.Compute.Contents BH.Engine.Excel.Compute.Note BH.Engine.Excel.Compute.NumberFormat BH.Engine.Excel.Convert.IToFormula BH.Engine.Excel.Convert.ToExcel BH.Engine.Excel.Convert.ToExpression BH.Engine.Excel.Convert.ToFormula BH.Engine.Filing.Convert.ToFile BH.Engine.Filing.Create.Directory BH.Engine.Filing.Create.File BH.Engine.Filing.Create.FileData BH.Engine.Filing.Create.FileSystem BH.Engine.Filing.Modify.Move BH.Engine.Filing.Modify.Rename BH.Engine.Filing.Query.Contents BH.Engine.Filing.Query.Encoding BH.Engine.Filing.Query.IsAcyclic BH.Engine.Filing.Query.Path BH.Engine.Geometry.Compute.CurveProximity BH.Engine.Geometry.Compute.SortAlongCurve BH.Engine.Geometry.Convert.ToNurbsCurve BH.Engine.Geometry.Convert.ToPolyline BH.Engine.Geometry.Create.AngleProfileCurves BH.Engine.Geometry.Create.BoxProfileCurves BH.Engine.Geometry.Create.ChannelProfileCurves BH.Engine.Geometry.Create.CircleProfileCurves BH.Engine.Geometry.Create.FabricatedBoxProfileCurves BH.Engine.Geometry.Create.GeneralisedFabricatedBoxProfileCurves BH.Engine.Geometry.Create.GeneralisedTeeProfileCurves BH.Engine.Geometry.Create.IProfileCurves BH.Engine.Geometry.Create.KiteProfileCurves BH.Engine.Geometry.Create.NurbsCurve BH.Engine.Geometry.Create.NurbsSurface BH.Engine.Geometry.Create.RandomNurbsCurve BH.Engine.Geometry.Create.RandomNurbsSurface BH.Engine.Geometry.Create.RectangleProfileCurves BH.Engine.Geometry.Create.TeeProfileCurves BH.Engine.Geometry.Create.TubeProfileCurves BH.Engine.Geometry.Create.ZSectionProfile BH.Engine.Geometry.Modify.CollapseToPolyline BH.Engine.Geometry.Modify.Extend BH.Engine.Geometry.Modify.Offset BH.Engine.Geometry.Modify.Project BH.Engine.Geometry.Modify.ProjectAlong BH.Engine.Geometry.Modify.SplitAtPoints BH.Engine.Geometry.Query.Area BH.Engine.Geometry.Query.BasisFunction BH.Engine.Geometry.Query.Centroid BH.Engine.Geometry.Query.ClosestPoint BH.Engine.Geometry.Query.DerivativeFunction BH.Engine.Geometry.Query.DiscontinuityPoints BH.Engine.Geometry.Query.Distance BH.Engine.Geometry.Query.EndDir BH.Engine.Geometry.Query.ExternalEdges BH.Engine.Geometry.Query.INormal BH.Engine.Geometry.Query.IsContaining BH.Engine.Geometry.Query.IsEqual BH.Engine.Geometry.Query.IsInPlane BH.Engine.Geometry.Query.IsLinear BH.Engine.Geometry.Query.IsOnCurve BH.Engine.Geometry.Query.IsPlanar BH.Engine.Geometry.Query.IsPolylinear BH.Engine.Geometry.Query.IsSelfIntersecting BH.Engine.Geometry.Query.Length BH.Engine.Geometry.Query.LineIntersections BH.Engine.Geometry.Query.MeshIntersections BH.Engine.Geometry.Query.Normal BH.Engine.Geometry.Query.Normals BH.Engine.Geometry.Query.ParameterAtPoint BH.Engine.Geometry.Query.PlaneIntersections BH.Engine.Geometry.Query.PointAtLength BH.Engine.Geometry.Query.StartDir BH.Engine.Geometry.Query.TangentAtLength BH.Engine.Grasshopper.Compute.IRenderMeshes BH.Engine.Grasshopper.Compute.IRenderRhinoMeshes BH.Engine.Grasshopper.Compute.IRenderRhinoWires BH.Engine.Grasshopper.Compute.IRenderWires BH.Engine.Grasshopper.Compute.RenderMeshes BH.Engine.Grasshopper.Compute.RenderRhinoMeshes BH.Engine.Grasshopper.Compute.RenderRhinoWires BH.Engine.Grasshopper.Compute.RenderWires BH.Engine.Grasshopper.Convert.FromGoo BH.Engine.Grasshopper.Convert.IFromGoo BH.Engine.Grasshopper.Convert.IToGoo BH.Engine.Grasshopper.Convert.IToNode BH.Engine.Grasshopper.Convert.ToDataParam BH.Engine.Grasshopper.Convert.ToGoo BH.Engine.Grasshopper.Convert.ToNode BH.Engine.Grasshopper.Convert.ToNodeGroup BH.Engine.Grasshopper.Convert.ToNodeParam BH.Engine.Grasshopper.Convert.ToReceiverParam BH.Engine.Grasshopper.Convert.ToRhino BH.Engine.Grasshopper.Convert.ToType BH.Engine.Grasshopper.Create.DataTree BH.Engine.Grasshopper.Query.RenderColour BH.Engine.Grasshopper.Query.RenderMaterial BH.Engine.Grasshopper.Query.Type BH.Engine.LDAP.Convert.FromLDAP BH.Engine.LifeCycleAssessment.Compute.EvaluateEnvironmentalProductDeclarationByArea BH.Engine.LifeCycleAssessment.Compute.EvaluateEnvironmentalProductDeclarationByMass BH.Engine.LifeCycleAssessment.Compute.EvaluateEnvironmentalProductDeclarationByVolume BH.Engine.LifeCycleAssessment.Compute.MaterialEndOfLifeTreatment BH.Engine.MEP.Create.CoolingCoil BH.Engine.MEP.Create.Create.CircularProperty BH.Engine.MEP.Create.Create.RectangularProperty BH.Engine.MEP.Create.Create.SectionProperty BH.Engine.MEP.Create.ElectricalConnector BH.Engine.MEP.Create.EnergyWheel BH.Engine.MEP.Create.Fan BH.Engine.MEP.Create.FanCoilUnit BH.Engine.MEP.Create.Filter BH.Engine.MEP.Create.GeometryFragment BH.Engine.MEP.Create.HeatingCoil BH.Engine.MEP.Create.IdentityFragment BH.Engine.MEP.Query.CircularEquivalentDiameter BH.Engine.MEP.Query.EquipmentLengthByPart BH.Engine.MEP.Query.HydraulicDiameter BH.Engine.MEP.Query.ICircularEquivalentDiameter BH.Engine.MEP.Query.MaterialComposition BH.Engine.MEP.Query.SolidVolume BH.Engine.Radiance.Compute.Analemma BH.Engine.Radiance.Compute.AnnualIlluminance BH.Engine.Radiance.Compute.AnnualRadiation BH.Engine.Radiance.Compute.ChunkByNumber BH.Engine.Radiance.Compute.ChunkBySize BH.Engine.Radiance.Compute.Chunkify BH.Engine.Radiance.Compute.ClosestNPoints BH.Engine.Radiance.Compute.DaylightFactor BH.Engine.Radiance.Compute.Dctimestep BH.Engine.Radiance.Compute.DiffuseSkyMatrix BH.Engine.Radiance.Compute.DirectSkyMatrix BH.Engine.Radiance.Compute.Epw2wea BH.Engine.Radiance.Compute.FibonacciSphereCartesian BH.Engine.Radiance.Compute.FibonacciSphereSpherical BH.Engine.Radiance.Compute.Gendaymtx BH.Engine.Radiance.Compute.Gensky BH.Engine.Radiance.Compute.GroundSky BH.Engine.Radiance.Compute.Oconv BH.Engine.Radiance.Compute.Rcalc BH.Engine.Radiance.Compute.Rcontrib BH.Engine.Radiance.Compute.Rfluxmtx BH.Engine.Radiance.Compute.RFluxSky BH.Engine.Radiance.Compute.Rmtxop BH.Engine.Radiance.Compute.Rtrace BH.Engine.Radiance.Compute.RunCommand BH.Engine.Radiance.Compute.SkyViewFactor BH.Engine.Radiance.Compute.SunMatrix BH.Engine.Radiance.Compute.TotalSkyMatrix BH.Engine.Radiance.Convert.FromRad BH.Engine.Radiance.Convert.ToRad BH.Engine.Radiance.Convert.ToRadFile BH.Engine.Radiance.Convert.ToRadString BH.Engine.Radiance.Convert.ToWea BH.Engine.Radiance.Create.SkyMatrix BH.Engine.Radiance.Query.CheckRadianceSettings BH.Engine.Radiance.Query.ExistsOnPath BH.Engine.Radiance.Query.GetFullPath BH.Engine.Reflection.Modify.PropertyValue BH.Engine.Reflection.Modify.SetPropertyValue BH.Engine.Rhinoceros.Convert.FromRhino BH.Engine.Rhinoceros.Convert.IToRhino BH.Engine.Rhinoceros.Convert.ToRhino BH.Engine.Rhinoceros.Convert.ToRhino5 BH.Engine.Rhinoceros.Convert.ToRhino6 BH.Engine.Rhinoceros.Create.RandomArc BH.Engine.Rhinoceros.Create.RandomArcCurve BH.Engine.Rhinoceros.Create.RandomCircle BH.Engine.Rhinoceros.Create.RandomControlPoint BH.Engine.Rhinoceros.Create.RandomCurves BH.Engine.Rhinoceros.Create.RandomLine BH.Engine.Rhinoceros.Create.RandomLineCurve BH.Engine.Rhinoceros.Create.RandomNurbsCurve BH.Engine.Rhinoceros.Create.RandomPoint3d BH.Engine.Rhinoceros.Create.RandomPoint3dList BH.Engine.Rhinoceros.Create.RandomPoint3f BH.Engine.Rhinoceros.Create.RandomPolyCurve BH.Engine.Rhinoceros.Create.RandomPolyline BH.Engine.Rhinoceros.Create.RandomPolylineCurve BH.Engine.Rhinoceros.Create.RandomVector3d BH.Engine.Rhinoceros.Create.RandomVector3f BH.Engine.Rhinoceros.Query.IIsEqual BH.Engine.Rhinoceros.Query.IsEqual BH.Engine.Rhinoceros.Query.IsPlanarSurface BH.Engine.Sharepoint.Convert.DecodeSharepointString BH.Engine.Sharepoint.Convert.IToCAML BH.Engine.Sharepoint.Convert.ToBHoM BH.Engine.Sharepoint.Convert.ToCAML BH.Engine.Sharepoint.Convert.ToFileCreationInformation BH.Engine.Sharepoint.Create.AndCondition BH.Engine.Sharepoint.Create.BeginsWithCondition BH.Engine.Sharepoint.Create.ContainsCondition BH.Engine.Sharepoint.Create.EqualCondition BH.Engine.Sharepoint.Create.GreaterCondition BH.Engine.Sharepoint.Create.GreaterEqualCondition BH.Engine.Sharepoint.Create.LessCondition BH.Engine.Sharepoint.Create.LessEqualCondition BH.Engine.Sharepoint.Create.Library BH.Engine.Sharepoint.Create.NotEqualCondition BH.Engine.Sharepoint.Create.OrCondition BH.Engine.Sharepoint.Create.SharepointRequest BH.Engine.Sharepoint.Query.GetMetadataMapping BH.Engine.Sharepoint.Query.GetMetadataMappingInverse BH.Engine.Sharepoint.Query.GetSharePointId BH.Engine.Structure.Create.FramingElement BH.Engine.Structure.Create.NewElement0D BH.Engine.Structure.Create.NewElement1D BH.Engine.Structure.Create.RigidLink BH.Engine.Structure.Query.AnalyticalBars BH.Engine.Structure.Query.Geometry BH.Engine.Structure.Query.IsVertical BH.Engine.Structure.Results.Query.MapResults BH.Engine.UI.Compute.Organise BH.Engine.UI.Convert.FromProperty ```

This is a significantly larger number of items failing so I will not post the versioning issues for previous version for now as this is already a decent task on its own. I am quite happy to see that the list is empty for objects that return null so hopefully, this is purely a question of either adding versioning for those items or marking them as exceptions

FraserGreenroyd commented 3 years ago

From the 3.3 to 4.0 list:

Assumed to be a problem with the base adapter:

Refactored beyond recognition per development agreement - exception should probably be added:

Versioning available here so should be upgrading correctly? Though objects may have changed similar to LCA objects as well as namespace changes between 3.3 and 4.0, so may be quicker to add an exception for this version

Deleted, exception should be added

Should have been versioned in recent PR on DIALux, but ultimately will be moved into an adapter convert folder which I can do today so add to an exception will be easier.

Deleted as only replicating default create methods

Deleted, exception needed

Moved to MachineLearning_Toolkit - versioning needed I guess but they're not being heavily used... so I'm not going to prioritise it but will try.

Separate issues have been raised to handle what I do need to handle in other toolkits so I presume that ends my 'assignment' to this issue, but please reassign if something else needed from me.

adecler commented 3 years ago

Thanks @FraserGreenroyd .

Worth noting a few things:

With that in mind, I think the list you provided above should be reviewed before making its way into the Exceptions file. I'd rather have some failing cases right now that just permanently ignored.

adecler commented 3 years ago

I have updated the list for 3.3 now that the script is able to ignore the methods that can be turned into auto-constructors.

FraserGreenroyd commented 3 years ago

Following this PR anything from DIALux can be added to exceptions as they've (finally) been moved to the Adapter folders.

Versioning for these were merged yesterday:

As discussed with @adecler this morning, LCA and MEP stuff will need to be resolved with input from @michaelhoehn and @kayleighhoude in the 4.1 milestone to resolve but should not be added as exceptions.

adecler commented 3 years ago

handled by https://github.com/BHoM/Versioning_Toolkit/pull/134