XML_Toolkit: Revisit UnitType in GBXML settings

BHoM / XML_Toolkit

GNU Lesser General Public License v3.0

9 stars 2 forks source link

XML_Toolkit: Revisit UnitType in GBXML settings #507

Closed BingWangUS closed 3 years ago

BingWangUS commented 3 years ago

Description:

Previous we are using UnitType(SI or IP) to set up the following configs in gbXML file (TemperatureUnit, LengthUnit, AreaUnit, VolumeUnit, UseSIUnitsForResults).

Recently we created a dedicated UnitSetUp object for TemperatureUnit, LengthUnit, AreaUnit and VolumeUnit. Only left UseSIUnitsForResults to be set up by unitType.

A review of UseSIUnitsForResults config is needed to identify how it impact out typical workflow.

if it does not have impact, we can remove unitType
if it does, we may want to rename and move it under UnitSetUp

FraserGreenroyd commented 3 years ago

Following sprint coordination, @BingWangUS and @KentonPhillips-BH to investigate the impact of non-SI results to inform further dev. :smile:

BingWangUS commented 3 years ago

@FraserGreenroyd a chat with Kenton lead us to the following decision:

Our current workflow with gbXML does not deal with results so far, so this input does not have any impact on our current workflow.
However, removing this input does not sound a correct move to us as we may use it in the future.
We recommend a rename of UnitType -> ResultsUnitType, to avoid confusion with UnitSetUp object.

FraserGreenroyd commented 3 years ago

That sounds fine to me @BingWangUS - it'll just need versioning but otherwise should be good.

FraserGreenroyd commented 3 years ago

Discussed in sprint coordination today, I will pick up the code actions on this following the investigation outlined above by @BingWangUS and @KentonPhillips-BH :smile: