search

BHoM / admin

Repository for raising central issues and questions; Regarding governance, process and multi-repo and framework compliance
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Checking versioning on new PRs #12

Closed adecler closed 3 years ago

adecler commented 3 years ago

Description:

It would be great to automaticalyl check that versioning is correct (and provided) on new PRs.

As suggested by @al-fisher: we could just serialise the objects and methods from the master and the deserialise them from the PR. The trick is going to filer the objects and methods that need to be tested.

FraserGreenroyd commented 3 years ago

This has now been implemented with a @BHoMBot check versioning command available for PRs. Needs to be examined as it's used to make sure it's doing the right thing, but follows the principle above with the measure of success against the existing state.

bhombot-ci[bot] commented 3 years ago
@FraserGreenroyd sorry, I didn't understand. Was that comment an instruction for me? If so, could you state again what check you would like me to do? For example, if you would like me to fix the CSProject file(s) comment: _"@BHoMBot fix project file"_