search

BHoM / bhom.github.io

Github pages repo for Buildings and Habitats object Model
2 stars 0 forks source link

bhom.github.io: <button> should not contain <a> #15

Closed FredericBourgeon closed 5 years ago

FredericBourgeon commented 5 years ago

The two <button> tags used on the why.html section have a <a> tag inside. HTML Spec states <button> tags should not contain interactive content (see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button).

It causes links to GitHub and Installer to fail on Firefox.

epignatelli commented 5 years ago

Thanks @FredericBourgeon for spotting it!

This feels quite urgent to me. If you feel confident with it, don't hesitate to raise a pull request.

Let me know If times are too tight, I will raise one at the end of the day.

I believe switching <button> to <a class="button-link"> and amending the core.scss would be enough. https://github.com/BHoM/bhom.github.io/blob/7e1e45678709bf289627ee870323a497396ba1ae/_sass/core.scss#L472-L483

Let me know If times are too tight, I will raise one at the end of the day.