search

BHoM / bhom.github.io

Github pages repo for Buildings and Habitats object Model
2 stars 0 forks source link

Add API files #43

Closed FraserGreenroyd closed 4 years ago

FraserGreenroyd commented 4 years ago

Issues addressed by this PR

Fixes #42

Test files

Changelog

Additional comments

FraserGreenroyd commented 4 years ago

I would personally say both of those items are outside the scope of the PR which focuses primarily on adding the capability for the API, but comments below:

If @IsakNaslundBh get's it done before 2 then yes.

  • [ ] The "\n" in descriptions are missing in the API rendering. These help with readability so needed here too as in UI. Can we keep?

Not in this PR scope - the "\n" has had to be stripped to allow the JSON to currently be generated and I wouldn't have time to regenerate before 2. This is best raised as a new issue to be resolved because I would not want to jeopardise what we currently have at this short notice.