search

BIC-MNI / libminc

libminc is the core library and API of the MINC toolkit
Other
19 stars 29 forks source link

Microsoft now supplies ``rint`` #77

Closed gdevenyi closed 7 years ago

gdevenyi commented 8 years ago

This needs some kind of version checking, newer versions of microsoft compilers supply rint.

https://github.com/BIC-MNI/libminc/blob/develop/libsrc2/minc2_private.h#L210

See https://github.com/CobraLab/atlases/issues/6

rdvincent commented 8 years ago

@gdevenyi Sure, I have made some effort to get the code building on Windows again, but progress has been slow.

vfonov commented 8 years ago

the last time I touched Windows development was a couple of years ago. Personally, I have no desire to do it again.

rdvincent commented 8 years ago

I understand...

gdevenyi commented 8 years ago

I know windows dev is an ugly ugly thing, but some ITK tools want a auto-building windows version, so if we want to get libminc into ITK's standard release we need to get it building on windows.

rdvincent commented 8 years ago

@gdevenyi No argument. It's mostly an issue of the availability of time and platforms...

vfonov commented 8 years ago

Well, officially we don't have any windows machines nor Visual Studio licenses in the lab, anyway.

rdvincent commented 8 years ago

@vfonov Exactly. I use one of my home machines to occasionally try to build for Windows. Adequate tools are available free.

thewtex commented 7 years ago

Addressed in #85