snprintf should be defined in time_stamp.c only for MSVC 2013

BIC-MNI / libminc

libminc is the core library and API of the MINC toolkit

Other

19 stars 29 forks source link

snprintf should be defined in time_stamp.c only for MSVC 2013 #91

Closed fbudin69500 closed 7 years ago

fbudin69500 commented 7 years ago

@thewtex My previous PR actually broke things with MSVC 2015. Moving the #define after including stdio.h solves the problem, but to avoid any other issue, I added a check of the version of Visual Studio. Potentially it could even be limited to VIsual Studio 2012 instead of VS2012 and below. Let me know what you think.

thewtex commented 7 years ago

Build errors identified by Travis.

fbudin69500 commented 7 years ago

@thewtex The error reported by travis does not seem related to my commit. It has to do with Cound not find NetCDF, on MacOS. Any idea why?

thewtex commented 7 years ago

@fbudin69500 I recall a different error, but I do not see it now. Marching forward...