Time to drop LD_LIBRARY_PATH?

BIC-MNI / minc-toolkit-v2

Version 2 of the minc-toolkit, uses tools based on ITK version 4.x

GNU General Public License v3.0

48 stars 21 forks source link

Time to drop LD_LIBRARY_PATH? #156

Open gdevenyi opened 2 years ago

gdevenyi commented 2 years ago

minc-toolkit-v2 appears to work properly (cursory testing) disabling LD_LIBRARY_PATH, but some things downstream of MINC may still need it

@bcdarwin how do you handle pyminc? I can't get it to load without LD_LIBRARY_PATH to MINC

gdevenyi commented 2 years ago

One possible solution for pyminc, https://github.com/Mouse-Imaging-Centre/pyminc/pull/41

vfonov commented 2 years ago

it doesn't actually need LD_LIBRARY_PATH, because on MACOS it was not working after some security update. I made sure that all binaries have properly set RPATHs

gdevenyi commented 2 years ago

okay, in theory ints not needed anymore, I'm removing it from my module settings for my latest deployment and I'll report back on testing.