search

BIC-MNI / minc-toolkit

Metaproject uniting all the available minc tools
GNU General Public License v3.0
37 stars 15 forks source link

Undeclared dependency, xfmavg depends on octave #19

Closed gdevenyi closed 5 years ago

gdevenyi commented 9 years ago

xfmavg generates an .m file and runs it through octave, which isn't listed in the dependencies of minc-toolkit

When it fails, it gives a cryptic error of xfmavg died on line 314

andrewjanke commented 9 years ago

Vladimir,

Where do you source xfmavg from in mind-toolkit? I just went looking for it with no luck? I have been making a repo of all these extras here:

https://github.com/BIC-MNI/minc-widgets

This is sort of my version of conglomerate. As for the bug itself yes including octave will fix it but I should also output an error message rather than the cryptic version. I can submit a fix to this in mind-widgets but wanted to make sure that you would then pick this up. Feel free to add an example CMAKE build file to mind-widgets for the version arguments and I'll make it work! I know how to do this in automake but haven't got around to figuring out how to do this with CMAKE. You'll note that most of the scripts have a PACKAGE, VERSION and PACKAGE_BUGREPORT variable def at the top all ready for this.

https://github.com/BIC-MNI/minc-widgets/blob/master/gennlxfm/gennlxfm#L22

Thanks

a

andrewjanke commented 9 years ago

I've made a commit to minc-widgets here:

https://github.com/BIC-MNI/minc-widgets/commit/25d72328a4dd2632124388c2c5ba19bfd0100f86

This should resolve this depending on where Vladimir sources xfmavg from.

vfonov commented 9 years ago

Currently i have it here: https://github.com/BIC-MNI/EZminc/blob/master/scripts/xfmavg

andrewjanke commented 9 years ago

Ah, there it is.

Perhaps best to add minc-widgets as a submodule, I see the CmakeLists.txt you have in that directory is close to what I want but doesn't have the version or maintainer info.

I have added the skeleton version for now based upon yours but haven't tested it.

https://github.com/BIC-MNI/minc-widgets/commit/59d583be4a4f1616e207fa5f584475b41f5aa11e

a