search

BIC-MNI / minc-tools

Basic minc-tools from former minc repository
Other
30 stars 25 forks source link

xfm2def discretisation #30

Open ajwood opened 8 years ago

ajwood commented 8 years ago

xfm2def is broken unless it's given -float or -double. To reproduce:

$ param2xfm -rotations 30 30 30 ./rot.xfm
$ xfm2def ./rot.xfm ./def_default.mnc
$ xfm2def ./rot.xfm -float ./def_float.mnc
$ minccmp ./def_default.mnc ./def_float.mnc

It also needs a VIO_ prefix added here and there, plus an entry inserted to CMakeLists.txt.

vfonov commented 8 years ago

up-to date version is here: https://github.com/BIC-MNI/EZminc/blob/develop/tools/xfm2def.c

ajwood commented 8 years ago

Does that fix this bug? Or just the VIO compiler errors?

Are there more tools that are diverging like this? How should one decide between a tool in minc-tools vs EZminc?

vfonov commented 8 years ago

I been using this through xfm_normalize.pl script ( https://github.com/BIC-MNI/EZminc/blob/develop/scripts/xfm_normalize.pl ) for the last 8 years. As you can see, with -float flag.

It was never officially part of minc-tools