search

BIC-MNI / minc-tools

Basic minc-tools from former minc repository
Other
29 stars 25 forks source link

minclookup does not support -labels #91

Closed gdevenyi closed 5 years ago

gdevenyi commented 5 years ago

minclookup's -discrete setting does not enforce the "no renormalization" needed to avoid messing up label numbers and -discrete doesn't turn on that handling either.

gdevenyi commented 5 years ago

Looks like based on https://github.com/BIC-MNI/minc-tools/commit/cc03c467df866a76f8a7eb0115ddc0fa10651fa1 its quite easy to add.

Does it make more sense to attach it to the -discrete option or add a -labels option (or both?)

vfonov commented 5 years ago

I would say it should be attached to both.

gdevenyi commented 5 years ago

will do!

stilley2 commented 5 years ago

Hi all,

Is there an easy workaround for this until the changes make it upstream?

Thanks!

gdevenyi commented 5 years ago

mincreshape -normalize -unsigned -byte -image_range 0 255 -valid_range 0 255 output_from_minclookup.mnc fixed.mnc

gdevenyi commented 5 years ago

Fixed by #92

stilley2 commented 5 years ago

Thanks!