search

BIDMCDigitalPsychiatry / AppMapDB

The Division of Digital Psychiatry AppMap database.
https://mindapps.org
1 stars 3 forks source link

reposition images #94

Closed ecamach13 closed 3 years ago

ecamach13 commented 3 years ago

Can we make it so that we can reposition images/zoom in/zoom out of them for the cover photos on the news tab

ecamach13 commented 3 years ago
Screen Shot 2021-06-09 at 11 36 24 AM
cvanem commented 3 years ago

This will require some custom implementation. I will take a look and see if there are any existing libraries we can easily plug in that will accomplish this.

cvanem commented 3 years ago

@ecamach13 I added the re-size and re-position to cover images when publishing content. This should work for most everything you need, but there are some image size limitations related to in-browser image editing and storing in the database. I have only found one image that exceeds the limits so far. So for this image, you would need to manually edit it and re-upload.

We could alternatively switch the image store to use an S3 bucket instead of a database, which would eliminate the size limitation. This would take a few more hours to implement, so please review and let me know if we need to do this or not.

jtorous commented 3 years ago

Let's keep the image size limits to keep it simpler.

-John

On Wed, Jun 23, 2021 at 3:08 AM Chris Van Emmerik @.***> wrote:

@ecamach13 https://github.com/ecamach13 I added the re-size and re-position to cover images when publishing content. This should work for most everything you need, but there are some image size limitations related to in-browser image editing and storing in the database. I have only found one image that exceeds the limits so far. So for this image, you would need to manually edit it and re-upload.

We could alternatively switch the image store to use an S3 bucket instead of a database, which would eliminate the size limitation. This would take a few more hours to implement, so please review and let me know if we need to do this or not.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BIDMCDigitalPsychiatry/AppMapDB/issues/94#issuecomment-866587940, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMFRAU3XCPCE2MDOXDOIBLTUGB7PANCNFSM46MJPCQA .

cvanem commented 3 years ago

Ok, will leave this as is and see how it works.