BIDMCDigitalPsychiatry / LAMP-platform

The LAMP Platform (issues and documentation).
https://docs.lamp.digital/
Other
13 stars 10 forks source link

Feed activities can't be clicked before scheduled time #393

Closed SuruPa00 closed 2 years ago

SuruPa00 commented 2 years ago

Users that go into the feed cannot click on a survey / activity ahead of the scheduled notification time. Users are meant to be able to enter the feed and complete the activities as they see fit.

sarithapillai8 commented 2 years ago

@avaidyam Could you please confirm on this? We did it like it should not be clickable before the scheduled time.

SuruPa00 commented 2 years ago

@sarithapillai8 this should clickable at anytime now, so if there any changes that need to be made to do that please do

sarithapillai8 commented 2 years ago

@SuruPa00 @avaidyam We implemented different conditions to control the clickable behavior of the feed items. For eg, with the repeat interval 3hour, we restricted the item like it can be clicked in between the 3hour gap comparing to current time. So there were a lot of checking for each repeat interval. It was implemented as Aditya said. So please confirm you want to remove all these conditions for all the repeat intervals. @michaelmenon @ZCOEngineer

avaidyam commented 2 years ago

@sarithapillai8 We'd like to keep the current implementation - thanks for bringing this up and reminding us about our prior discussion!


Sidenote for others stumbling across this GitHub issue: If we allowed patients to disregard their notification schedule, there really would not be a point to the notification schedule, breaking the notion of ecological (i.e. "in the field where the patient is") momentary (i.e. "brief, in the moment the patient needs to respond") assessment (i.e. "surveys") (EMA) that we rely on mindLAMP for.

If the patient really does need to take the survey independently of notification schedule, the clinician should enable the activity to appear in the Learn tab, where they can take it without being restricted by existing schedule. If the clinician does NOT want to allow patients to take surveys outside of notification schedules, they should hide the survey from all tabs -- see #165.

SuruPa00 commented 2 years ago

@sarithapillai8 what is the window that users cannot access their survey before the designated time again? is at midnight est? we want to know if we can extend that to be longer so that people of different time zones can access the surveys later if their time is scheduled later.

Ex. access a survey meant for 9pm at 1am.

sarithapillai8 commented 2 years ago

@SuruPa00 The feed schedule will work based on the local time-zone. That means when you schedule an activity, the selected time will be converted and saved in UTC format. Then the feed will be showing by converting the UTC time to the user's local time-zone. The clickable conditions are based on this. This was done as @avaidyam asked.
@avaidyam Please confirm on this.

SuruPa00 commented 2 years ago

@sarithapillai8 just spoke with aditya, this is confirmed

SuruPa00 commented 2 years ago

As discussed, this functionality will be kept for now till further notice