BIDMCDigitalPsychiatry / LAMP-platform

The LAMP Platform (issues and documentation).
https://docs.lamp.digital/
Other
13 stars 10 forks source link

Reintegrate WearOS codebase into main branch of LAMP-core-android #532

Open avaidyam opened 2 years ago

avaidyam commented 2 years ago

(See discussion from issue #476.)

@saranya-sajeev: Wear os app and phone app are separate code bases. So we have to create two folders under Lamp- core repository, one for WearOs app and other for Phone app. Shall we proceed with this?

@avaidyam: The WearOS codebase should NOT be separate. It is a module within the same Gradle project as the mobile app. It will have a separate folder under the LAMP-core-android repository, yes, just like how the Apple Watch app has its own folder in the LAMP-core-ios repository.

saranya-sajeev commented 2 years ago

@avaidyam ok.

michaelmenon commented 2 years ago

Saranya is going to working on this from tomorrow after the Telephony updates are done.

saranya-sajeev commented 2 years ago

@avaidyam do you need to keep wear os in a separate folder in the master branch or do you want it within the mindLamp source?

avaidyam commented 2 years ago

@saranya-sajeev It should a separate module (i.e. folder, with its own build.gradle) but in the master branch. Please follow the instructions provided by Google here if you're still unsure.

ZCOEngineer commented 2 years ago

Ok Aditya, @saranya-sajeev will comment on this one the workflow is corrected.

saranya-sajeev commented 2 years ago

@avaidyam I will integrate wear os code in master right after you create the release. Otherwise, there may be issues with code references.

saranya-sajeev commented 2 years ago

@avaidyam WearOs code integrated to master branch.

avaidyam commented 2 years ago

So if I make a new release for Android, it will also appear available for WearOS?

saranya-sajeev commented 2 years ago

@avaidyam yes it should work, but yesterday it is not worked. May be any issues with wear os workflow. We will check and update you.

saranya-sajeev commented 2 years ago

@aditya wear os workflow is not shown under actions tab? Do you have any suggestions?

avaidyam commented 2 years ago

@saranya-sajeev Unfortunately I don't. It should be included in the Gradle build process if you've added it as a submodule correctly. Please consult the Android/wearOS documentation.

saranya-sajeev commented 2 years ago

@avaidyam We have moved the mindLamp code to main directory and put the wear os code inside mindLamp project. Then we have modified the mindLamp app workflow to build the WearOs code. We have faced some issues on building the code using workflow and finally, we have built the code. After that, we started to sign the apk. We are getting the below issue while signing the apk and we are working on it. jarsigner: unable to sign jar: java.util.zip.ZipException: invalid entry compressed size (expected 78895 but got 80894 bytes)

saranya-sajeev commented 2 years ago

@avaidyam We have created a separate workflow file for WearOs. We will merge it to the main workflow once it is completed. Now it is showing following error and we are working on it. We have checked the syntax on yamllint and it says it is valid.

Error: .github#L1 every step must define a uses or run key

saranya-sajeev commented 2 years ago

@avaidyam We have fixed the above error and now we are getting the old jarsigner. error. jarsigner: unable to sign jar: java.util.zip.ZipException: invalid entry compressed size (expected 78895 but got 80894 bytes)

saranya-sajeev commented 2 years ago

@avaidyam We have fixed the jar signer issue, it was due to the signing configuration already defined in the build.gradle file.

saranya-sajeev commented 2 years ago

@avaidyam Now we got below issue. I thnik it is due to same package name used for both mindLamp and wearos. We wil check on it. Error: Error: APK specifies a version code that has already been used.

saranya-sajeev commented 2 years ago

@avaidyam wearosa pp and minLamp should have same package name and so we have added an empty commit in wear os workflow to make the version code different. Currently we are getting below error and we are working on it.

You cannot rollout this release because it does not allow any existing users to upgrade to the newly added APKs.

saranya-sajeev commented 2 years ago

@avaidyam We assume that the above issue is due to the wear app is referring mindLamp app. Shall we try to upload from a different branch to check whether it works?