search

BIDMCDigitalPsychiatry / LAMP-platform

The LAMP Platform (issues and documentation).
https://docs.lamp.digital/
Other
12 stars 10 forks source link

Unable to select 12 in time picker #615

Closed lukeoftheshire closed 2 years ago

tlakhtak commented 2 years ago

https://user-images.githubusercontent.com/82968538/164771934-e011b18a-ef3d-4d50-84bb-582197004638.MP4

Image from iOS

sarithapillai8 commented 2 years ago

@avaidyam It was done like 00:00 AM is for 12 am. It was asked to keep the range 0-12(standard) and 0-24(military) in the requirement - https://github.com/BIDMCDigitalPsychiatry/LAMP-platform/issues/404. FYI 0 to 23 need to be kept for military time as there will not be a way to set time like 12.15am or 12.45am. We will be changing the standard time.

divyav2020 commented 2 years ago

We have updated the time range from 1 to 12 (Standard) in Production

While testing, we have got an issue in Military time update.

sarithapillai8 commented 2 years ago

@avaidyam @divyav2020 Issue fix including UI fixes (LAMP-Activities) are updated in production. Survey military time update issue is fixed (LAMP-dashboard) in dashboard-staging. Production update required. @avaidyam Is it possible to have a hotfix release for this?

divyav2020 commented 2 years ago

Tested the time range update (Standard time) and UI fixes in Production.

We have updated the Military time Issue fixes in Staging.

avaidyam commented 2 years ago

@sarithapillai8 @divyav2020 We can't do a hotfix for this so it will need to wait for the early May release.

@lukeoftheshire Would you mind verifying this issue is resolved on both production and staging?

lugray1 commented 1 year ago

This seems to be fixed in staging! 🎉