BIDMCDigitalPsychiatry / LAMP-platform

The LAMP Platform (issues and documentation).
https://docs.lamp.digital/
Other
13 stars 10 forks source link

Jewels Issues Tracker #616

Open lukeoftheshire opened 2 years ago

lukeoftheshire commented 2 years ago

Currently the code for Jewels has a few problems. It is essentially undocumented, which makes it difficult to figure out what each function does. In addition to this:

lukeoftheshire commented 2 years ago

There are 4 settings that control how much time participants have for each test:

'beginner_seconds': 95,
    'intermediate_seconds': 30,
    'advanced_seconds': 25,
    'expert_seconds': 15,

However, there is no code that can change the difficulty during the game itself that I can see and mode itself is a seperate setting that appears to only control which of these seconds keys is used. Additionally, neither the mode variable nor the actual time allotted is stored in the ActivityEvent data.

I think we should consider removing these 5 variables and replacing them with a single time_allotted or similar variable. Additionally, I think it's important to store the time in static data in case either the time or the difficulty setting is later changed.

lukeoftheshire commented 2 years ago

Once this is resolved, the page at https://docs.lamp.digital/data_science/data_types/activity_types should be updated to reflect any changes.