search

BIDMCDigitalPsychiatry / LAMP-platform

The LAMP Platform (issues and documentation).
https://docs.lamp.digital/
Other
12 stars 10 forks source link

Matrix Survey Response renders textbox instead of matrix #632

Closed tlakhtak closed 2 years ago

tlakhtak commented 2 years ago

We found an issue with all of the matrix surveys on the LAC version of the dashboard after they updated to the latest version (2022.4.23). See images below. All of the matrix surveys turned into text boxes thumbnail_image001 thumbnail_image002

All of the questions on the matrix surveys disappeared: thumbnail_image003

avaidyam commented 2 years ago

@sarithapillai8 I suspect this is due to #442? Is this expected behavior? If so, @tlakhtak, the guidance here would be to re-create the survey as it should work correctly then.

sarithapillai8 commented 2 years ago

@avaidyam Yes this is expected behavior. First question is matrix type and there is no preceding type, it will render as text. If the first question is rating and next is matrix, then it will show as matrix with rating options.

tlakhtak commented 2 years ago

This implementation is not very clear or obvious without this comment, unlike the other survey types. I was only able to make a matrix survey following the instructions provided above, and I have some follow up questions after receiving the following output.

Screen Shot 2022-05-10 at 3 00 48 PM
  1. The star is not in red so it is not clearly indicating that it is a required question.
  2. What is the purpose of having the rating description be redundantly described with each question instead of preserved at the top as it was previously? This seems to take up more screen space instead of preserving space, which is what we would want for the mobile app.
  3. This should not have broken backwards compatibility for previous matrix questions, as this creates serious implementation issues.
sarithapillai8 commented 2 years ago

@tlakhtak Please provide the survey details to understand how you created your questions. https://github.com/BIDMCDigitalPsychiatry/LAMP-platform/issues/442#issuecomment-1029194134 Please have a look at this for understanding how to create matrix questions.

The star is not in red so it is not clearly indicating that it is a required question.

I can check and update this.

sarithapillai8 commented 2 years ago

The star is not in red so it is not clearly indicating that it is a required question.

This is fixed and updated in dashboard-staging.

avaidyam commented 2 years ago

This should not have broken backwards compatibility for previous matrix questions, as this creates serious implementation issues.

@tlakhtak @sarithapillai8 Going forwards our team will be strict about any kind of data format or API change that affects implementation and compatibility across sites. Anything JSON/API related must be shared in full detail and approved by myself and @lukeoftheshire before merging into staging.