Closed ertjlane closed 2 years ago
@avaidyam The tag color appearing for both active and passive data are based on the passive data(gps/accelerometer). Tooltip is showing based on last activity event data for "Last Active" and sensor data for "Last passive". Is it to ok show different colors for the tag? The code from old version also showing the same. That same functionality was reusing here.
https://github.com/BIDMCDigitalPsychiatry/LAMP-dashboard/blob/rev-coding/src/components/ParticipantList.tsx#L766 https://github.com/BIDMCDigitalPsychiatry/LAMP-dashboard/blob/rev-coding/src/components/ParticipantList.tsx#L992
@sarithapillai8 Yes, the colors should be different and it looks like the code to show that exists. Why isn't it working?
@avaidyam The colors will be same as both based on passive data now. Tooltip shows the correct data. I can change it to show based on last activity event data. One more think to confirm - 'Last active' is actually considering latest activity event data timestamp. The tooltip includes the latest activity event timestamp and the last login time in brackets. So these values might not match all the time. User might have logged in recently, but with old activity event data. Is there any change required? What is actually expected there?
@avaidyam One more thing to clarify. Do we need to show latest update by fetching the data frequently? We decided to fetch only the messages frequently from participant side. and remove all other repeated calls. So please confirm.
No, you don't have to show the latest data always. I'm not sure what you mean by the proposed change. Can you provide an explanation/diagram/mockup?
Like you can see, the tool tip showing different date range. In brackets you can see last login date time and 3weeks ago is the latest activity event submission date time. I was asking about this. What is actually expected here?
Note: This screenshot is after changing 'Last Active' tag color change with correct active data in development environment. Not available in dashboard-staging. Otherwise the colors will be same.
@avaidyam
I don't think anything else is necessary here. The issue was that "Never" would show as green and if that has been fixed, it should be fine.
@avaidyam I hope the date time showing in tooltip is fine. I asked for the clarification because it is little bit confusing. 3 weeks ago an activity event generated, but last login done today. Color changes are done and QA testing on that was completed in ZCO staging. We can update it in dashboard staging now if no more changes are required.
Tag color is based on activity event data submission, not on login time.
Yes, that's fine.
We have updated in staging
This appears to be resolved in staging!
Describe the bug On the mindLAMP dashboard, the tag 'last active data' has been providing reports of active data inconsistent with the data portal. The tag further appears green, despite reporting 'never'.
Expected behavior The recent active data tags show the most recent active data shown in the portal, and if there are none, appear gray, rather than green.
Screenshots
Desktop (please complete the following information):