search

BIDMCDigitalPsychiatry / LAMP-platform

The LAMP Platform (issues and documentation).
https://docs.lamp.digital/
Other
13 stars 10 forks source link

mindLAMP Activities Not Loading #724

Closed ertjlane closed 1 year ago

ertjlane commented 1 year ago

Describe the bug Activities within the app are not loading, but are endlessly buffering. This is true across devices (smartphones and desktop), and across mindLAMP servers. It occurred shortly after this update to mindLAMP. This has occurred in previous updates, but never for this long. Because this appears to be an issue with the update instantiating, this issue will not be present on dashboard-staging. mindlamp error

To Reproduce Go to lamp-dashboard, or any lamp account and open an activity - could be learn, manage, or otherwise, the result has been the same.

falmeida-orangeloops commented 1 year ago

Working on it

falmeida-orangeloops commented 1 year ago

@ertjlane Here's what I found:

When the dashboard is going to load an activity, it makes a request to GitHub to retrieve the HTML source of the activity from a file in the BIDMCDigitalPsychiatry/LAMP-activities repository. Which file is downloaded depends on whether you are in dev or in production environment. For example, if I try to access a journal activity from the staging dashboard (dev environment) the file from the following URL is retrieved:

https://raw.githubusercontent.com/BIDMCDigitalPsychiatry/LAMP-activities/dist/out/journal.html.b64

This means the out/journal.html.b64 file from the dist branch. On the other hand, if you use the production dashboard (production environment), the following URL is used:

https://raw.githubusercontent.com/BIDMCDigitalPsychiatry/LAMP-activities/latest/out/journal.html.b64

This points to the out/journal.html.b64 file from the latest branch. The problem is that the latest branch does not exist in this repo, so the request returns 404. The dashboard lacks visual error handling for this, so it shows the loading indicator, but actually the problem is that it didn't find the file it is looking for.

I don't know about your deployment process, but it seems like the BIDMCDigitalPsychiatry/LAMP-activities repo must have a latest branch with an out directory (similar to the one in the dist branch) for the dashboard to work on production. Could you confirm that?

falmeida-orangeloops commented 1 year ago

Actually it seems like latest is supposed to be a tag, not a branch. The file tree of the commit that your latest tag is pointing to does not contain the out directory. You need to update that tag to a commit that does.

ertjlane commented 1 year ago

Thanks for this Facundo! The issue has been resolved for the time being.