BIDMCDigitalPsychiatry / LAMP-platform

The LAMP Platform (issues and documentation).
https://docs.lamp.digital/
Other
12 stars 10 forks source link

Exposure Module in mindLAMP Digital Clinic Not Appearing #725

Closed ertjlane closed 1 year ago

ertjlane commented 1 year ago

Describe the bug Question labels are not appearing for a specific activity in the manage section of the ''vqgvp6v3axr0mbst1nrx' investigator account. This is not occurring on other activities within the investigator account, or other activities on mindLAMP. Note: when going into edit activities, questions are written out as they should be in the editor. Not all of the questions have missing descriptions, but the majority do. Please let me know if additional information is required.

To Reproduce log into mindLAMP - api.lamp.digital. (production or staging dashboard) go to 'vqgvp6v3axr0mbst1nrx' Go into dummy account Go into manage. Open 'Exposure'.

Screenshots

Screen Shot 2022-12-22 at 1 52 02 PM Screen Shot 2022-12-22 at 1 51 49 PM
falmeida-orangeloops commented 1 year ago

Noted, will try to take a look before the end of tomorrow.

falmeida-orangeloops commented 1 year ago

Found the source of this issue. It is related to translations (relevant i18next issue). In short, this results in question labels ending with a colon being "hidden".

We have at least two options:

  1. Remove the trailing colon from all question labels in that particular activity (quickest fix).
  2. Add the following line here:
    nsSeparator: false,

    This is in my opinion the best one because it would prevent you from running into this issue in the future. I can do it if it's okay for you.

ertjlane commented 1 year ago

Yes, option two sounds great, thank you! As implied by your assessment, this issue is popping up in other activities (those where question descriptions end with a colon).

falmeida-orangeloops commented 1 year ago

I think most probably yes.

Done and merged! BIDMCDigitalPsychiatry/LAMP-activities#242

ertjlane commented 1 year ago

Great, this looks like it's fixed in testing!