BIDMCDigitalPsychiatry / LAMP-platform

The LAMP Platform (issues and documentation).
https://docs.lamp.digital/
Other
13 stars 10 forks source link

LAMP server silently fails #785

Closed baylisscg closed 8 months ago

baylisscg commented 11 months ago

Describe the bug The Encrypt and Decrypt functions swallow any errors that occur. See here and here

To Reproduce

Self evident from code but for giggles start up a instance of LAMP server with a ROOT_KEY generated from openssl rand -base64 32 it'll start normally but you won't be able to log in with the auto-created admin credential.

Expected behaviour

Any config issues that would prevent proper functioning should be flagged to the user at startup. Any runtime issues should be accurately reflected back to the user. e.g. the login code not returning a 403 when it should be some flavour of 500.

carlan1 commented 8 months ago

Nice catch. We've added error messages for this occurrence.