BIG-RAT / Managed-App-Schema-Builder

Creates JSON file that can be used to set application preferences
MIT License
92 stars 3 forks source link

Configured / Not Configured no longer needed (and seems to no longer work) #7

Open talkingmoose opened 11 months ago

talkingmoose commented 11 months ago

Earlier versions of Jamf Pro supported the option to create Configured / Not Configured settings for keys to make them visible but “turned off”.

Jamf Pro no longer seems to support this option and it’s really not necessary today with improvements made over the past years.

I suggest removing this altogether.

Today, Managed App Schema Builder produces JSON like this:

{
    "title": "Disk Manager (com.company.diskmanager)",
    "description": "Preference settings for the fictitious Disk Manager application. This manifest demonstrates different ways to format the appearance or value of properties as well as include useful options like infoText. Jamf Pro supports many but not all elements and options here: https://github.com/json-editor/json-editor.",
    "properties": {
        "askForPassword": {
            "title": "askForPassword",
            "description": "Set Disk Manager application to require a password.",
            "property_order": 5,
            "anyOf": [
                {"type": "null", "title": "Not Configured"},
                {
                    "title": "Configured",
                    "type": "Select Value Type"
                }
            ]
        }
    }
}

Let’s simplify it to this:

{
    "title": "Disk Manager (com.company.diskmanager)",
    "description": "Preference settings for the fictitious Disk Manager application. This manifest demonstrates different ways to format the appearance or value of properties as well as include useful options like infoText. Jamf Pro supports many but not all elements and options here: https://github.com/json-editor/json-editor.",
    "properties": {
        "askForPassword": {
            "title": "Ask For Password",
            "description": "Set Disk Manager application to require a password.",
            "property_order": 25,
            "type": "boolean"
        }
    }
}

This change applies to all property types not just boolean.

BIG-RAT commented 5 months ago

removal planned for next release??

BIG-RAT commented 5 months ago

Appears setting a key to "Not Configured" still hides the key from the list. Could this have been changed back?

talkingmoose commented 5 months ago

Appears setting a key to "Not Configured" still hides the key from the list. Could this have been changed back?

The original intent for the anyOf keyname and its "Not Configured" setting was to make all keys viewable back when Jamf Pro didin't display configured keys. That behavior is changed now. This has no good use anymore.