Misspelling of `spotIdentifier` field on `Order`

BILDIT-Platform / react-native-bildit-flybuy

React Native FlyBuy module. Supports Core, Pickup, Notify, and Presence Native SDK APIs.

9 stars 6 forks source link

Misspelling of `spotIdentifier` field on `Order` #92

Closed botnerd closed 2 months ago

botnerd commented 2 months ago

The spotIdentifier field on the order is misspelled as spotIdentifer. In order to fix without breaking apps using the wrapper when upgrading, add a new spotIdentifier field and deprecate the misspelled spotIdentifer.

addingama commented 2 months ago

@botnerd The fix can't be done from the native side

CleanShot 2024-09-11 at 16 43 48@2x

the typescript type is correct, it's expecting spotIdentifier

CleanShot 2024-09-11 at 16 45 40@2x

The changes needed should be updating the SDK to expose the correct attribute