BIM2SIM / bim2sim

A python tool to create simulation models for different domains based on BIM IFC models.
https://bim2sim.github.io/bim2sim/
GNU Lesser General Public License v3.0
43 stars 7 forks source link

move plugin sim_settings to plugins #583

Open veronikarichter opened 9 months ago

veronikarichter commented 9 months ago

Currently, all sim_settings for the main plugins are defined inside the kernel sim_settings. However, to enable full modularity, sim_settings should be defined inside the individual plugins. Currently, there are some issues when writing a new plugin and adding new sim_settings directly to the plugin.

The all_subclasses function used in the project setup here, only finds available sim_settings that are included in sim_settings.py, but not directly in the plugins (even if the plugin-sim_settings inherit from existing sim_settings).

I would suggest moving the plugin-specific sim_settings to the plugins and fix this issue project wide, so we don't get caught when adding additional sim_settings.