E.g. with digital hub we have the problem that the most upper horizontal slab consists of the actual roof and another slab "Geschossdecke" as shown in the screenshot below.
The issue is that only the most upper one (lets name it Slab1) is an IfcSlab with PredefinedType=Roof and the second one from above (Slab2) is a normal IfcSlab with PredefinedType=Floor. As only Slab2 has direct contact to the IfcSpaces below, there are only SpaceBoundaries between Slab2 and the IfcSpace.
This leads to issues in both, PluginEnergyPlus and PluginTEASER, which are based on the same.
As PluginEnergyPlus directly creates the slabs and other structures in EnergyPlus based on the SpaceBoundaries and it's type (external or internal), we have the correct typing here, so the displayed Space will have a roof, but this will only have the thickness and the material structure from Slab2. When using material enrichment this leads to the issue that a Roof exists in the IDF but has the material structure of an interior floor, as the bim2sim kernel inspects the element as an interior floor based on its predefined type.
As PluginTEASER only uses the SpaceBoundary areas to disaggregate the Slabs into zonal parts but also uses the SpaceBoundaries to decide which Disaggregation to allocate to which ThermalZone, we will have no Roof at all for the displayed ThermalZone but only an interior Floor.
At least when using material enrichment this can be fixed for both Plugins by checking the assignment of the type of a Slab (and also Walls) not only based on the predefined type but also on the type of the SpaceBoundary, if the SpaceBoundary is correct.
A future approach should use a geometric algorithm. This has to be discussed.
E.g. with digital hub we have the problem that the most upper horizontal slab consists of the actual roof and another slab "Geschossdecke" as shown in the screenshot below.![Pasted image 20240227162251](https://github.com/BIM2SIM/bim2sim/assets/27726960/222c92aa-55cf-481b-9361-caeb645ae47f)
The issue is that only the most upper one (lets name it
Slab1
) is anIfcSlab
withPredefinedType=Roof
and the second one from above (Slab2
) is a normalIfcSlab
withPredefinedType=Floor
. As onlySlab2
has direct contact to theIfcSpaces
below, there are onlySpaceBoundaries
betweenSlab2
and theIfcSpace
.This leads to issues in both, PluginEnergyPlus and PluginTEASER, which are based on the same.
PluginEnergyPlus
directly creates the slabs and other structures in EnergyPlus based on theSpaceBoundaries
and it's type (external or internal), we have the correct typing here, so the displayed Space will have a roof, but this will only have the thickness and the material structure fromSlab2
. When using material enrichment this leads to the issue that a Roof exists in the IDF but has the material structure of an interior floor, as the bim2sim kernel inspects the element as an interior floor based on its predefined type.PluginTEASER
only uses theSpaceBoundary
areas to disaggregate the Slabs into zonal parts but also uses theSpaceBoundaries
to decide which Disaggregation to allocate to whichThermalZone
, we will have no Roof at all for the displayedThermalZone
but only an interior Floor.At least when using material enrichment this can be fixed for both Plugins by checking the assignment of the type of a Slab (and also Walls) not only based on the predefined type but also on the type of the
SpaceBoundary
, if theSpaceBoundary
is correct.A future approach should use a geometric algorithm. This has to be discussed.