search

BIMSBbioinfo / ciRcus

An R package for annotation of circular RNAs
10 stars 5 forks source link

static code analyis with lintr #28

Closed mschilli87 closed 7 years ago

mschilli87 commented 7 years ago

This PR adds lintr to the test suite to ensure that style guidelines met so far remain respected.

The .lintr file lists the linters skipped (for now) as those would result in a failed test.

Eventually, all of the should be enabled unless we explicitely decide to break one of the recommendations (see #27).

mschilli87 commented 7 years ago

@retaj: I think this is ready for merge as it add extra tests that currently don't fail.

So if you agree, feel free to merge this PR, but please dont delete the lint branch as I will keep working on #27.

mschilli87 commented 7 years ago

@retaj: Please don't merge as of now.

It seems 0fb797a71bd594d9d300ac12818216ff101f6f07 did not only disable linting for inst/scripts/test_load_data.R, but in general.

I'm working on a fix.

mschilli87 commented 7 years ago

@retaj: fixed by b4f942be59bbfb01f7913204a896d59c80901b6c

Turns out Debian Control Field Format is very sensitive to newlines...