BIMSBbioinfo / ciRcus

An R package for annotation of circular RNAs

10 stars 5 forks source link

added bedTracks function (incl. tests) #39

Closed mschilli87 closed 7 years ago

mschilli87 commented 7 years ago

Not quite sure if I should target dev or master for this now. We did not release 0.1.5 in the end, did we? So I guess this could still go in. But then the changelog would need adjustment, too.

@retaj: I targeted dev for now not to screw things for you but by all means feel free to merge this to master.

codecov-io commented 7 years ago

Codecov Report

Merging #39 into dev will increase coverage by 1.75%. The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev      #39      +/-   ##
==========================================
+ Coverage   59.31%   61.07%   +1.75%     
==========================================
  Files           9       10       +1     
  Lines         676      763      +87     
==========================================
+ Hits          401      466      +65     
- Misses        275      297      +22

Impacted Files	Coverage Δ
R/circus.R	`0% <ø> (ø)`	:arrow_up:
R/exportData.R	`74.71% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 781d7b6...e8be25e. Read the comment docs.

mschilli87 commented 7 years ago

@retaj: I'm done rebasing on dev & sqaushing everything into two (nice?) commits, one per new function.

bedTracks() comes with its own tests, writeBedTracks() was tested by installing from this branch & actually using it on my data (looks fine at first glance).

Please review this to make sure I didn't forget anything and merge this pull-request if it looks good to you.

mschilli87 commented 7 years ago

closing & re-open to re-trigger pull-request test with force-pushed fixes

mschilli87 commented 7 years ago

once more for e8be25e2ed4fb26adcc25499ca8e5a64e34cc0e0

mschilli87 commented 7 years ago

For some reason, the tests don't start seems to be a Travis CI issue. I'll just wait a bit to see if it fixes itself. ;)

mschilli87 commented 7 years ago

We finally are ready to merge this! :tada:

@retaj : That is if you agree to what you see here. :wink:

I resolved the missing ... documentation warning by documenting it in a kind of useless way but I don't think documentation guidelines should block new features.

Shall I open an issue to remind us to check how to do this 'properly'?