BIMSBbioinfo / ciRcus

An R package for annotation of circular RNAs

10 stars 5 forks source link

get rid of lintr config copy #40

Closed mschilli87 closed 6 years ago

mschilli87 commented 7 years ago

see https://github.com/jimhester/covr/issues/253#issuecomment-293659424

codecov-io commented 7 years ago

Codecov Report

Merging #40 into dev2 will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             dev2      #40   +/-   ##
=======================================
  Coverage   61.07%   61.07%           
=======================================
  Files          10       10           
  Lines         763      763           
=======================================
  Hits          466      466           
  Misses        297      297

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b55f5d...01fb6a2. Read the comment docs.

mschilli87 commented 7 years ago

@retaj: This also finally runs without error.

So please go ahaed and merge if it looks good to you.

mschilli87 commented 7 years ago

I have no idea why this triggered windows testing. The dev branch works and the only difference between dev and lint is cd46991993a8b533c555b502155e49837956af39. I'll investigate and update again.

mschilli87 commented 7 years ago

closing to re-open to get rid of win testing

mschilli87 commented 7 years ago

@retaj: So it seams like the windows test is somehow left as at some point you merged the wintest branch into dev and appveyor doesn't get that there is no appveyor.yml anymore in either of the branches.

I don't know how to change this and I don't think its worth the time finding out. As there should be no windows testing done on the PR, we can safely ignore that it fails.

So please go ahead and merge this. As there is no windows testing on dev everything will be fine once this is merged.