search

BIMSBbioinfo / ciRcus

An R package for annotation of circular RNAs
10 stars 5 forks source link

Cleanup leftover code #50

Open mschilli87 opened 6 years ago

mschilli87 commented 6 years ago

Remove assembly2organism which was defined in circus.R but not used anywhere else.

When it was introduced in 82b261e491e18ad4750da53f64296c8ec88036bb it used be used in annotate.R, but that is no longer the case.

mschilli87 commented 6 years ago

see https://github.com/BIMSBbioinfo/ciRcus/pull/51#issuecomment-403014011 regarding the CI failures

mschilli87 commented 5 years ago

rebased on latest dev hoping for CI not failing anymore now that f5305346e4ae0e1d62af9f5b0fe352efdd410376 is in.

codecov-io commented 5 years ago

Codecov Report

Merging #50 into dev will increase coverage by 0.31%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #50      +/-   ##
==========================================
+ Coverage   58.55%   58.87%   +0.31%     
==========================================
  Files          10       10              
  Lines         736      727       -9     
==========================================
- Hits          431      428       -3     
+ Misses        305      299       -6
Impacted Files Coverage Δ
R/circus.R 0% <0%> (ø) :arrow_up:
R/annotate.R 79.39% <0%> (-1.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f530534...c1b1da2. Read the comment docs.

mschilli87 commented 5 years ago

Yeah! @retaj: This is ready to merge.