BIMSBbioinfo / pigx_bsseq

bisulfite sequencing pipeline from fastq to methylation reports
https://bioinformatics.mdc-berlin.de/pigx/
GNU General Public License v3.0
11 stars 4 forks source link

Right now only one round of diffmeth is incorporated into the report #77

Closed alexg9010 closed 6 years ago

alexg9010 commented 6 years ago

Right now only one round of diffmeth is incorporated into the report

Blosberg commented 6 years ago

When I submit as follows:

  differential-methylation:
    cores: 20
    treatment-groups:
      - ['0', '1'],
        ['0', '2']
    annotation:
...

I get the following errors:

$ ./pigx-bsseq test/samplesheet.csv -s test/settings.yaml  
Traceback (most recent call last):
  File "./pigx-bsseq", line 402, in <module>
    args.settings)
  File "./pigx-bsseq", line 236, in generate_config
    update_config(settings,yaml.safe_load(open(settingsfile, 'r')))

So I guess the first thing to clarify is what the right syntax is to enter multiple treatments.

rekado commented 6 years ago

Groups have to be specified as arrays. In YAML that's done like this:

  differential-methylation:
    cores: 20
    treatment-groups:
      - ['0', '1']
      - ['0', '2']
    annotation:
...

An alternative is to use JSON syntax (which we already do for the groups themselves), i.e. square brackets for arrays/lists.

Blosberg commented 6 years ago

We decided that to solve this issue, it's ok to have differential methylation output a separate html report for each comparison. I'd recommend adding such an html file to the OUTPUT_FILES for each treatment group, and then just have the rule run arbitrarily many times.

Is that the approach? I'm just wondering what the status of this is.

alexg9010 commented 6 years ago

Yes, exactly. If I remember correctly I asked Kasia to take over, so you might ask her if she already made progress on this.

katwre commented 6 years ago

sorry guys, I didn't see your msgs! I took over this issue