BIMSBbioinfo / pigx_sars-cov-2

PiGx SARS-CoV-2 wastewater sequencing pipeline
GNU General Public License v3.0
18 stars 3 forks source link

Set mutation covered percentage threshold in tests to 25 #128

Closed jonasfreimuth closed 2 years ago

jonasfreimuth commented 2 years ago

This leads to enough samples being used that the mutation regression will run, meaning now most analysis code actually runs now during testing. The results may be unrealistic, but we don't care about that during testing.

jonasfreimuth commented 2 years ago

Changed to 25%, as 20% can lead to inconsistencies between differnt data loading due to a bug when loading mutations files where one column is always "T", which would have been read in as "TRUE" when using read.table (and wrappers).

rekado commented 2 years ago

This looks good to me, though I'd prefer to have a comment in the settings file. Better to have it where we can see it instead of just the git log.

jonasfreimuth commented 2 years ago

Will do.