Open vicfabienne opened 3 years ago
This is a weird format for discussing changes :-/
Anyway, here are some comments:
Only on the MDC NFS server. It can also take days, though, if you choose to build everything from source (including compiler toolchains). So I'd prefer not to mention time at all.
No. We are unsetting the prompt variable. This is the default prompt of Bash. It's not unusual, it's just unconfigured. Mentioning that environment variables are unset with --pure
is sufficient.
It no longer fails because we include diffutils
.
No, users can use whatever tools they want. We only restrict the environment for development, so that we don't accidentally depend on tools at runtime that are not part of the reproducible environment. Users can set PATH
to whatever value they want (it's just reset like all the other variables because of --pure
), or they can use the absolute file name of whatever executable they want to use.
No, see above. Use absolute file names.
210604_documentation_feedback.md
Introduciotn
"of all reads which are not aligned to SARS-CoV-2." counter intutive formulation - "unaligned reads" would be more clear
Workflow
Output
Installation
[x] "going to be packaged soon" ---> "IS packaged"
[x] "from source" - but also with guix. Why? Is it possible to use anything else? How and/or Why not?
[ ] we should be provide clear step-by-step instruction on how the set up works with - and without guix if that is possible - of course also always mentioning why that is not favorable and providing the direct links on how to quick-set-up guix first on local machines if that is possible.
[x] mention that it is ok, that setting the environment can take up to 10min
[x] also mention that the terminal prefix has "sh-4.2$" then - this is super confusing
[x] The vep test fails !!!
[x] mention to use "cat" to investigate logs
[x] or can we maybe have an editor?
Getting started
Preparing the input
[x] "the user must supply" - we switched to an active language befor already so we should be consistent with that.
[ ] "type in the shell" --> "give command", "use folowing command", just smth with "command line interface" or "terminal"
[x] what is a boilerplate? --- "boilerplate" is a bunch of standard unspecific text
[ ] can or should I do smth with that know? It is only stuff described, but not if I have to do anything with that.
[ ] where do I find them now?
[ ] !! How about the actual working directory?
[x] !! I can't create a seperate working directory and use --init there - can I somehow? --- yes, you can, just don't use
PIGX_UNINSTALLED
[x] !! also that environment doesn't show the directory I'm in, this is confusing --- that's up to your shell settings
[ ] !! document where this --init sample sheet comes from, intuitively I would assume that this is already dynamically created
[ ] !! since it is not dynamic - can we make a template which does not contain all the 12 test samples?
-[ ] ! double check and state if there are still any restirictions on the name of the read files (e.g. nothing allowed between _R1.fastq)
Pipeline help
Prepare databases