search

BIOP / abba_python

ABBA, controlled from python
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Better fix for doi parsing #31

Open NicoKiaru opened 1 week ago

NicoKiaru commented 1 week ago

I'm trying to retrieve the doi of the atlases from BrainGlobe here: https://github.com/BIOP/abba_python/blob/0e8cab336e8eb80562ce18ff86d2d5cc17b21261/src/abba_python/abba_atlas.py#L46-L49

However I had to catch an exception for the kim_mouse_idisco atlas (and probably others).

A better fix would be nice, I need to print and look at it.

adamltyson commented 1 week ago

We don't enforce any kind of structure for the citation string, but we probably should. I've raised https://github.com/brainglobe/brainglobe-atlasapi/issues/404 to track this. It probably won't be a quick fix unfortunately though.